Switched to Into<Option<T>> for parameters in Builder #185
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I know this is minor, but it seems so much nicer for optional parameters in a public API to take
Into<Option<T>>
rather than just takingOption<T>
. That way the user can just send a value ofT
forSome<T>
, and of course can still sendNone
when desired.Thus we could do:
rather than
but,
min_idle(Some(2))
andmin_idle(None)
still work, so it's all backward compatible.