Add new statistics for knowing when and why connections were closed #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We add 4 new statistics which will be used by the users for knowing when the connections were closed and what was the reason, the new four statistics are: - `connections_closed_broken`: Total connections that were closed due to be in broken state. - `connections_closed_invalid`: Total connections that were closed due to be considered invalid. - `connections_closed_max_lifetime`: Total connections that were closed because they reached the max lifetime. - `connections_closed_idle_timeout`: Total connections that were closed because they reached the idle timeout.
djc
reviewed
Jun 11, 2024
| @@ -85,7 +87,7 @@ where | |||
| } | |||
|
|
|||
| pub(crate) async fn get(&self) -> Result<PooledConnection<'_, M>, RunError<M::Error>> { | |||
| let mut kind = StatsKind::Direct; | |||
| let mut kind = StatsGetKind::Direct; | |||
There was a problem hiding this comment.
Please put this change in a separate commit or PR.
| @@ -139,22 +143,34 @@ where | |||
| ApprovalIter { num: num as usize } | |||
| } | |||
|
|
|||
| pub(crate) fn reap(&mut self, config: &Builder<M>) -> ApprovalIter { | |||
| pub(crate) fn reap(&mut self, config: &Builder<M>) -> (ApprovalIter, u64, u64) { | |||
There was a problem hiding this comment.
Let's split the reap() changes out in a separate PR.
| @@ -272,6 +292,28 @@ impl AtomicStatistics { | |||
| .fetch_add(wait_time.as_micros() as u64, Ordering::SeqCst); | |||
| } | |||
| } | |||
|
|
|||
| pub(crate) fn record_connection_closed(&self, kind: StatsConnectionClosedKind) { | |||
|
Closing this one in favour of #205 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We add 4 new statistics which will be used by the users for knowing when the connections were closed and what was the reason, the new four statistics are:
connections_closed_broken: Total connections that were closed due to be in broken state.connections_closed_invalid: Total connections that were closed due to be considered invalid.connections_closed_max_lifetime: Total connections that were closed because they reached the max lifetime.connections_closed_idle_timeout: Total connections that were closed because they reached the idle timeout.