Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move shared WGSL code to imported module #264

Merged
merged 6 commits into from
Dec 27, 2023
Merged

Move shared WGSL code to imported module #264

merged 6 commits into from
Dec 27, 2023

Conversation

djeedai
Copy link
Owner

@djeedai djeedai commented Dec 27, 2023

Move most shared WGSL code into an import module vfx_common.wgsl, and
document it. This ensures the code remains in sync between the various passes
(init/update/render) without needing some error-prone copy/paste, while making
the code easier to read too.

This change moves naga and naga_oil from being dev-only dependencies to
being proper crate dependencies. This is required to use naga_oil's import
system, like bevy_render. This makes the change a breaking one.

@djeedai djeedai added A - internal Internal change on a core system C - breaking change A breaking API or behavior change labels Dec 27, 2023
@djeedai djeedai merged commit 5a3685d into main Dec 27, 2023
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A - internal Internal change on a core system C - breaking change A breaking API or behavior change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant