Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression in flipbook #293

Merged
merged 1 commit into from
Mar 2, 2024
Merged

Fix regression in flipbook #293

merged 1 commit into from
Mar 2, 2024

Conversation

djeedai
Copy link
Owner

@djeedai djeedai commented Mar 2, 2024

Fix a regression in the flipbook shader code where some variable previously emitted as i32 by error instead of its actual u32 type is now producing the correct literal value, resulting in an invalid shader operation between mismatching operand types. Cast the value to i32 explicitly before emitting the shader code to ensure the value is emitted in the expected type.

Fix a regression in the flipbook shader code where some variable
previously emitted as `i32` by error instead of its actual `u32` type is
now producing the correct literal value, resulting in an invalid shader
operation between mismatching operand types. Cast the value to `i32`
explicitly before emitting the shader code to ensure the value is
emitted in the expected type.
@djeedai djeedai added the C - bug Something isn't working label Mar 2, 2024
@djeedai djeedai merged commit 37e7927 into main Mar 2, 2024
13 checks passed
@djeedai djeedai deleted the u/sprite-index-u32 branch March 2, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C - bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant