Fix new linter: remove std::mem::
#352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djeedai
added a commit
that referenced
this pull request
Aug 5, 2024
Rust 1.80 added `size_of()` and `align_of()` to the prelude. However Bevy's MSRV (and therefore Hanabi's) is 1.79, so still require the `std::mem::` qualification. This reverts commit 0663370.
djeedai
added a commit
that referenced
this pull request
Aug 5, 2024
Rust 1.80 added `size_of()` and `align_of()` to the prelude. However Bevy's MSRV (and therefore Hanabi's) is 1.79, so still require the `std::mem::` qualification. This reverts commit 0663370.
djeedai
added a commit
that referenced
this pull request
Aug 5, 2024
* Revert "Fix new linter: remove `std::mem::` (#352)" Rust 1.80 added `size_of()` and `align_of()` to the prelude. However Bevy's MSRV (and therefore Hanabi's) is 1.79, so still require the `std::mem::` qualification. This reverts commit 0663370. * Remove `unused_qualifications` linter flag This is necessary to build both with MSRV 1.79 (where `size_of()` needs the `std::mem::` qualification) and 1.80 (where it was added to prelude and doesn't need it). Otherwise there's always one version which fails to build. Fixes #360 * Add MSRV build to CI * Run CI on hotfix/* branches * Clippy fixes * v0.12.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #351