-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change the ribbon example into a tracer example. #380
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I understand correctly you're proposing to replace the purely GPU driven motion with a property-based one, to show how a ribbon can follow a target as a kind of trail, is that it?
I don't have any objection, but if you feel that tracers are common (I don't have an opinion, probably that's correct) then I'd expand a tiny bit the top level documentation to mention that this example shows a "tracer" (so that if someone search that term they find that example) and explain how a property is used to link the particle position to some CPU position (as this is probably a common feature to want).
Screen.Recording.2024-10-15.at.21.23.02.mov |
Is there anything else you'd like me to do with this or should I close it? Maybe move to a separate example? |
This is fine by me. Note that the little gaps between ribbon segments are something I've been thinking about fixing with the singly linked list experiment (that needs #387 to land first). |
No worries friend ❤️! I'll take care of it! |
8508ca1
to
b6ba52e
Compare
I think that does it. Could use a final review |
@naasblod the example fails to build:
|
@djeedai should be fixed now. |
@naasblod for next time, if you need a dependency for examples and tests only, you can add it to the |
Ah! Thanks, that's useful to know! |
I think this could be more helpful for people wanting to use the ribbon example. In my mind "tracers" are the most used application for this sort of thing, If you feel it isn't just close it.
run with:
cargo run --example ribbon --features="bevy/bevy_winit bevy/bevy_pbr 3d bevy/bevy_gizmos"