Optimize BufferTable<T>
#385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clean-up and optimize `BufferTable<T>`: - Change row counts to `u32` type; this helps a bit readability. - Fix doc link. - Use `mapped_at_creation` to upload the newly added data when a new `Buffer` is created, instead of doing some buffer copies. This ensures all new rows are copied in a single call, and makes better use of the WGPU staging buffer. This change should not alter any behavior. It was originally a tentative workaround for some bug with Metal debugging, but proved useless for that purpose. However the minor optimization and code clean-up are nonetheless relevant.
djeedai
added
C - enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean-up and optimize
BufferTable<T>:u32type; this helps a bit readability.mapped_at_creationto upload the newly added data when a newBufferis created, instead of doing some buffer copies. This ensures all new rows are copied in a single call, and makes better use of the WGPU staging buffer.This change should not alter any behavior. It was originally a tentative workaround for some bug with Metal debugging, but proved useless for that purpose. However the minor optimization and code clean-up are nonetheless relevant.