Null dereference on Permission Application for Lights #18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there, not sure if this repo is maintained much, but I have been using this kernel module for quite some time.
I recently was working on some code on my main desktop and noticed that the module would have the following kernel oops when plugging in the piuio.
So according to the stack trace, that's the function that applies the permissions for the lighting in
/sys/class/leds
.I ran into a similar issue when developing
hid-itgio
which I have published in my account, so I modified the function as follows.I am currently running
5.9.14-arch1
so I am uncertain when this null pointer was going against the standard of the linux kernel, or if it is a recent addition, but this has been working for me and it allowed me to continue developing lighting drivers for stepmania.Please let me know what you think or if you see any issues with the way that I modified the code.
Thank you for your work.