Skip to content

Commit

Permalink
removed workaround for new commit dialog because it doesn't work in t…
Browse files Browse the repository at this point in the history
…he latest IntelliJ
  • Loading branch information
dkandalov committed Nov 23, 2024
1 parent 26fe6bc commit b9e4c2e
Showing 1 changed file with 0 additions and 11 deletions.
11 changes: 0 additions & 11 deletions src/ijkl/event-redispatch.kt
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,6 @@ interface KeyEventContext {
val hasParentTree: Boolean
val hasParentCommitDialog: Boolean
val hasParentWizardPopup: Boolean
val isNewCommitDialog: Boolean
val isPopupActive: Boolean
}

Expand All @@ -112,7 +111,6 @@ private class Context(focusOwnerFinder: FocusOwnerFinder, ideEventQueue: IdeEven
override val hasParentTree by lazy(NONE) { component.hasParentTree() }
override val hasParentCommitDialog by lazy(NONE) { component.hasParentCommitDialog() }
override val hasParentWizardPopup by lazy(NONE) { component.hasParentWizardPopup() }
override val isNewCommitDialog by lazy(NONE) { component.toString().contains("EditorComponent") }
override val isPopupActive by lazy(NONE) { ideEventQueue.isPopupActive }
}

Expand Down Expand Up @@ -180,15 +178,6 @@ private inline fun KeyEvent.mapIfIjkl(context: KeyEventContext): KeyEvent? {
}
}

// Starting from #IU-192.5281.24 (2019.2 EAP) there is new commit dialog
// which seems to be "stealing" alt+i from editor (probably for "Commit" button mnemonics).
// This is a workaround to make sure editor receives alt+i as VK_UP.
if (context.isNewCommitDialog) {
when (keyCode) {
VK_I -> return copyWithoutAlt(VK_UP)
}
}

if (context.isPopupActive) {
if (context.hasParentWizardPopup) {
when (keyCode) {
Expand Down

0 comments on commit b9e4c2e

Please sign in to comment.