Fix bugzilla 24524: Very slow process fork if RLIMIT_NOFILE is too high #9077
Conversation
|
Thanks for your pull request, @schveiguy! Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + phobos#9077" |
|
@LightBender please don't auto merge before allowing others to review. |
| @@ -1106,6 +1155,7 @@ private Pid spawnProcessPosix(scope const(char[])[] args, | |||
| // Until we find a way to perform this check we will try to use dlsym to | |||
| // check for the function. See: https://github.com/dlang/phobos/pull/9048 | |||
| version (CRuntime_Glibc) | |||
| { | |||
There was a problem hiding this comment.
FYI, this confused me, because of the block declaration inside. Using version/else without braces always bugs me.
schveiguy
force-pushed
the
new8990
branch
2 times, most recently
from
6e9dd6c
to
e1da63d
Compare
|
|
||
| int fd = atoi(cast(char*) entry.d_name); | ||
|
|
||
| // Don't close stdin, stdout, stderr, or the directory file descriptor |
There was a problem hiding this comment.
Meh, effectively it's correct.
|
Some projects are more picky with how they want their commit history to look like so, given that @schveiguy's changes were pretty minimal on top of @trikko's, can the commit be reworded to reference the original author and include @schveiguy as a Also, if there's any relevant information surrounding the commit (like the fact that this is a refactor of a another PR) can it be included in the commit message to make it easier to find it in the future? |
|
I don't need credit here, I didn't really do much. But if one looks at the PR you can see the credit via the description and the references. I've spent enough time on this, if someone cares to make the changes, go ahead. |
Replaces #8990, refactored after merge of #9048
Credit to @trikko