[experiment] Add resource time limit and rate limiting #1485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dlt-hub-docs canceled.
|
sh-rp
commented
Jun 18, 2024
| if max_items >= 0 or max_time and not self.incremental: | ||
| from dlt.common import logger | ||
|
|
||
| logger.warning( |
There was a problem hiding this comment.
this will need to be improved a bit, but I think this is a quite nice solution.
There was a problem hiding this comment.
also: generally speaking it would be cool to have some wrapper around log messages to be able to test them, maybe mocking would be enough, not sure
sh-rp
commented
Jun 18, 2024
| while (last_iteration + min_wait) - time.time() > 0: | ||
| # we give control back to the pipe iterator | ||
| yield None | ||
| time.sleep(0.1) |
There was a problem hiding this comment.
we could make this configurable, I am not sure wether it is needed though.
sh-rp
commented
Jun 18, 2024
| @@ -788,52 +788,6 @@ def test_add_transformer_right_pipe() -> None: | |||
| iter([1, 2, 3]) | dlt.resource(lambda i: i * 3, name="lambda") | |||
|
|
|||
|
|
|||
| def test_limit_infinite_counter() -> None: | |||
There was a problem hiding this comment.
these three tests were moved to the new location where a couple more tests will be added specifically for the limits
rudolfix
force-pushed
the
devel
branch
2 times, most recently
from
2ee3eab
to
e48f641
Compare
sh-rp
force-pushed
the
exp/more-limits
branch
from
6126895
to
5fc2324
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR extends the add_limit function to add time limits and rate limits to resources. This approach is to be discussed, but very straightforward, easy to test and works for both sync and async resources.
TODOs (if we go this route):
Other thoughts: