Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using Voice class instead of Map + Including gender when available #269

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

CodingAleCR
Copy link

@CodingAleCR CodingAleCR commented Aug 24, 2021

Problem

I needed access to the underlying gender APIs provided by iOS, however it had to be done on a library level.

Changelog

  • Converts Maps of voices into a proper Dart class called TTSVoice.
  • Provides a somewhat reliable API for checking gender in voices from Android or iOS platforms.

@CodingAleCR
Copy link
Author

CodingAleCR commented Aug 24, 2021

I know this might not be the most elegant solution, but it does work on android and iOS devices.

Ps: I also am aware that this might be a breaking change, so it could be an opportunity to convert the library into objects instead of generic and dynamic types. 😉

@dlutton dlutton self-requested a review August 24, 2021 17:06
@dlutton dlutton self-assigned this Aug 24, 2021
@dlutton
Copy link
Owner

dlutton commented Aug 24, 2021

great idea @CodingAleCR and thank you for this PR. I'll probably start a pre-release to version 4 and include this in that while other objects are being integrated in place of dynamics.

Copy link
Owner

@dlutton dlutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@theatifwaheed
Copy link

@dlutton When will this PR be merged ?

@dlutton
Copy link
Owner

dlutton commented Mar 24, 2024

@theatifwaheed I intend to include this in the next major release. I want to fix a couple of more bugs, add minor enhancements, and add unit tests first. Next major release I'm hoping to include this change including other returned objects and support for Linux.

@mobiluse
Copy link

Acknowledged @dlutton
I also figured 2 issues.
I fixed in the https://github.com/theatifwaheed/flutter_tts Fork of this Branch.

@mobiluse
Copy link

Build.VERSION.SDK_INT < 26
Doesn't calls the function in new phones.

also,
set Handlers were not working
I just shifted FlutterTts _channel.setMethod... to a new function as functions were empty when constructor is called and then they are not called when setProgress or other handlers setting is called.

cc @dlutton

@dlutton
Copy link
Owner

dlutton commented Mar 24, 2024

@mobiluse

Are those fixes for the current version? If so do you mind adding a new PR for those and I can get them merged in.

Thanks!

@theatifwaheed
Copy link

@dlutton I'm @mobiluse xD
I've created the PR.

@CodingAleCR
Copy link
Author

It's been a while since I made this, LMK if there's any support that I can give. Kudos for the work! 👌🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants