-
-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using Voice class instead of Map + Including gender when available #269
base: master
Are you sure you want to change the base?
Conversation
I know this might not be the most elegant solution, but it does work on android and iOS devices. Ps: I also am aware that this might be a breaking change, so it could be an opportunity to convert the library into objects instead of generic and dynamic types. 😉 |
great idea @CodingAleCR and thank you for this PR. I'll probably start a pre-release to version 4 and include this in that while other objects are being integrated in place of dynamics. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@dlutton When will this PR be merged ? |
@theatifwaheed I intend to include this in the next major release. I want to fix a couple of more bugs, add minor enhancements, and add unit tests first. Next major release I'm hoping to include this change including other returned objects and support for Linux. |
Acknowledged @dlutton |
Build.VERSION.SDK_INT < 26 also, cc @dlutton |
Are those fixes for the current version? If so do you mind adding a new PR for those and I can get them merged in. Thanks! |
It's been a while since I made this, LMK if there's any support that I can give. Kudos for the work! 👌🏼 |
Problem
I needed access to the underlying gender APIs provided by iOS, however it had to be done on a library level.
Changelog
TTSVoice
.