Skip to content

Commit

Permalink
commented out test 3/4 for undecided list coercion. Also changed test…
Browse files Browse the repository at this point in the history
… 7 to reflect Octavian comment re 'two things wrong in the same test'
  • Loading branch information
StrayAlien committed Nov 12, 2023
1 parent 3a11d0f commit ee45581
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@
</resultNode>
</testCase>

<!-- commented out pending RTF. https://github.com/dmn-tck/tck/pull/602#issuecomment-1770863632 -->
<!--
<testCase id="003">
<description>Will return null when 'in' expression is not a list</description>
<resultNode name="decision003" type="decision" errorResult="true">
Expand All @@ -32,7 +34,10 @@
</expected>
</resultNode>
</testCase>
-->

<!-- commented out pending RTF. https://github.com/dmn-tck/tck/pull/602#issuecomment-1770863632 -->
<!--
<testCase id="004">
<description>Will not coerce single value 'in' expression to list - and return null</description>
<resultNode name="decision004" type="decision" errorResult="true">
Expand All @@ -41,6 +46,7 @@
</expected>
</resultNode>
</testCase>
-->

<testCase id="005">
<description>Will return null when 'satisfies' does not return boolean</description>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,21 +25,27 @@
</some>
</decision>

<!-- commented out pending RTF. https://github.com/dmn-tck/tck/pull/602#issuecomment-1770863632 -->
<!--
<decision name="decision003" id="_decision003">
<variable name="decision003"/>
<some iteratorVariable="element">
<in><literalExpression><text>"not a list"</text></literalExpression></in>
<satisfies><literalExpression><text>element</text></literalExpression></satisfies>
</some>
</decision>
-->

<!-- commented out pending RTF. https://github.com/dmn-tck/tck/pull/602#issuecomment-1770863632 -->
<!--
<decision name="decision004" id="_decision004">
<variable name="decision004"/>
<some iteratorVariable="element">
<in><literalExpression><text>1</text></literalExpression></in>
<satisfies><literalExpression><text>element * 2</text></literalExpression></satisfies>
</some>
</decision>
-->

<decision name="decision005" id="_decision005">
<variable name="decision005"/>
Expand All @@ -61,7 +67,7 @@
<variable name="decision007"/>
<some iteratorVariable="element">
<in><literalExpression><text>[]</text></literalExpression></in>
<satisfies><literalExpression><text>"not a boolean"</text></literalExpression></satisfies>
<satisfies><literalExpression><text>true</text></literalExpression></satisfies>
</some>
</decision>

Expand Down

0 comments on commit ee45581

Please sign in to comment.