-
-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix comparison when layout differs #111
Fix comparison when layout differs #111
Conversation
In case `layoutDifference` is `true` `compColor` is assigned incorrect pixel value read from `base` instead of `comp`.
It would be amazing if you can add a test case that would fail with the previous implementation |
I have no idea how to add new image files, because they are not being copied to the |
intersting we have one of the existing tests failing could you please elaborate more on why do you think the existing test is wrong |
I can understand that current value of |
The following pixels are considered different (where previously weren't) after this fix:
|
I added a new test. Locally I had to copy the new images manually to |
I updated expects for the failing test 🤷 |
In case
layoutDifference
istrue
compColor
is assigned incorrect pixel value read frombase
instead ofcomp
.