Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove old crab cache code #5115

Merged
merged 2 commits into from
Nov 19, 2021
Merged

Remove old crab cache code #5115

merged 2 commits into from
Nov 19, 2021

Conversation

belforte
Copy link
Member

No description provided.

@belforte belforte requested a review from ddaina November 18, 2021 17:56
@belforte
Copy link
Member Author

@ddaina I defer on you on when it the proper time to merge.

ddaina
ddaina approved these changes Nov 19, 2021
View reviewed changes
Copy link
Contributor

@ddaina ddaina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes looks good, we can merge anytime.

@belforte
Copy link
Member Author

thanks @ddaina . I am merging now so I can take care of reopening #5114 before I forget

@belforte belforte merged commit 25502cb into dmwm:master Nov 19, 2021
@belforte belforte deleted the removeOldCrabCacheCode branch November 19, 2021 09:22
@belforte belforte mentioned this pull request Nov 23, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddaina ddaina ddaina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@belforte @ddaina