Refactoring RunConfigAPI.configureRun()

[gkfthddk]

Replay Request

Requestor
Team or person that requests this replay

Describe the configuration

• Release:
• Run:
• GTs:
  • expressGlobalTag:
  • promptrecoGlobalTag:
• Additional changes:

Purpose of the test
A replay test is costly, both in computational and human resources. Please describe the reason why this test is needed.

T0 Operations cmsTalk thread
If necessary, provide a link to the cmsTalk thread announcing the test to the relevant groups.
Tier0 Operations cmsTalk Forum

[germanfgv]

@gkfthddk It looks good! We need to test it before we can merge it. Can you create some simply unit tests for the new functions you created?

They should be located here:
https://github.com/dmwm/T0/tree/master/test/python/T0_t/RunConfig_t

[gkfthddk]

run unit test please

[cmsdmwmbot]

Container Tests
Unit tests finished

[cmsdmwmbot]

Container Tests
Unit tests finished

[gkfthddk]

run unit test please

[cmsdmwmbot]

Container Tests
Unit tests finished

[gkfthddk]

I'm worried that the separation of functions and shortening of lines have made the script too arbitrary.

[gkfthddk]

@germanfgv How can I run unit test? The unit test at jenkins fails.

[germanfgv]

Please add your unit test in a different file, specific to RunConfigAPI. Put it in the same folder, with name RunConfigAPI_t.py

About running the test, you may find the information you need here:
https://cms-wmcore.docs.cern.ch/wmcore/setup-wmcore-unittest/#executing-wmcore-unittest

You can run it in one of our VMs

[germanfgv]

@gkfthddk I fixed a conflict introduced by recent developments. Also, I added instructions to our doc on how to run Unit Tets
https://cmst0.docs.cern.ch/dev/t0agent/#running-unit-tests

[germanfgv]

I think if looks good and you came up with good ideas on how to reduce duplicate code. Please add docsctrings to the new functions you created. Focus on describing what the function does in the context of T0. I made a few suggestion of changes to islustrate this point.

Consider also to add or modify existing comments in the sections of code you have modified.

[germanfgv]

I removed insertDAO mapping as the names in the mappings were wrong and I prefer having the individual DAOs for readability