Allow Partial Parentage #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d issue with parentage check Kept validation check Partial Parentage is indicated by providing -1 to ChildParentIDList Only insert valid parentage
|
@d-ylee Hi Dennis, I am working on the relevant changes on the WMAgent side, basically:
I should have those ready today, such that we can proceed with some basic tests. |
|
@d-ylee Dennis, from my side we can go ahead and merge this pull request and make it available in testbed for further testing. Thank you for preparing it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Issue #94:
These changes allow Partial Parentage to be provided. In order to provide partial parentage, the client must provide a
missing_filesfield in the JSON Body.missing_filesis used to validate that the number of child-parent file id pairs that do not have parentage are purposefully provided by each client. If a client provides an incorrect number ofmissing_files, then the request will fail.missing_fileswill default to 0, preserving the previous behavior.