Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for registrant APIs #146

Merged
7 commits merged into from
Aug 24, 2023
Merged

Add support for registrant APIs #146

7 commits merged into from
Aug 24, 2023

Conversation

ghost
Copy link

@ghost ghost commented Aug 22, 2023

This PR introduces 5 new endpoints that are part of the domain contact management API that was introduced in dnsimple/dnsimple-developer#501.

The following endpoints have been added:

  • listRegistrantChanges: GET /{account}/registrar/registrant_changes
  • createRegistrantChange: POST /{account}/registrar/registrant_changes
  • checkRegistrantChange: POST /{account}/registrar/registrant_changes/check
  • getRegistrantChange: GET /{account}/registrar/registrant_changes/{registrantchange}
  • deleteRegistrantChange: DELETE /{account}/registrar/registrant_changes/{registrantchange}

Belongs to https://github.com/dnsimple/dnsimple-business/issues/1729

@ghost ghost added the enhancement New feature, enhancement or code changes, not related to defects label Aug 22, 2023
@ghost ghost self-assigned this Aug 22, 2023
@ghost ghost self-requested a review August 22, 2023 05:09
Copy link
Contributor

@DXTimer DXTimer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only the create registrant change endpoint has been added please add all 5 endpoints for the registrant change API: list, check, create, show, delete.

Tests are missing.

dnsimple/registrar.go Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
dnsimple/registrar.go Outdated Show resolved Hide resolved
@ghost ghost changed the title Add support to create a registrant change Add support for registrant APIs Aug 23, 2023
@ghost ghost requested a review from DXTimer August 23, 2023 13:36
Copy link
Contributor

@DXTimer DXTimer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments, otherwise, this is good to go.

dnsimple/registrar_registrant.go Outdated Show resolved Hide resolved
@ghost ghost merged commit e03e247 into main Aug 24, 2023
5 checks passed
@ghost ghost deleted the feature/create-registrant-change branch August 24, 2023 06:07
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, enhancement or code changes, not related to defects
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant