-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for registrant APIs #146
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only the create registrant change endpoint has been added please add all 5 endpoints for the registrant change API: list, check, create, show, delete.
Tests are missing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments, otherwise, this is good to go.
This PR introduces 5 new endpoints that are part of the domain contact management API that was introduced in dnsimple/dnsimple-developer#501.
The following endpoints have been added:
/{account}/registrar/registrant_changes
/{account}/registrar/registrant_changes
/{account}/registrar/registrant_changes/check
/{account}/registrar/registrant_changes/{registrantchange}
/{account}/registrar/registrant_changes/{registrantchange}
Belongs to https://github.com/dnsimple/dnsimple-business/issues/1729