Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DomainRegistrantChange event types #148

Merged
4 commits merged into from
Sep 11, 2023

Conversation

ghost
Copy link

@ghost ghost commented Sep 1, 2023

Add the struct type for the domain.registrant_change events.

Belongs to https://github.com/dnsimple/dnsimple-business/issues/1729

@ghost ghost added the enhancement New feature, enhancement or code changes, not related to defects label Sep 1, 2023
@ghost ghost self-requested a review September 1, 2023 05:08
@ghost ghost self-assigned this Sep 1, 2023
dnsimple/webhook/events.go Show resolved Hide resolved
@ghost ghost requested a review from DXTimer September 1, 2023 06:14
@DXTimer DXTimer requested a review from AGS4NO September 5, 2023 12:11
Copy link
Contributor

@DXTimer DXTimer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add tests for the new events in events_test.go?

@ghost ghost requested a review from DXTimer September 6, 2023 14:12
@ghost ghost merged commit 157f867 into main Sep 11, 2023
5 checks passed
@ghost ghost deleted the feature/domain-registrant-change-event branch September 11, 2023 11:29
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, enhancement or code changes, not related to defects
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant