Replace Ace Editor with CodeMirror #4933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niknetniko
added
the
enhancement
niknetniko
force-pushed
the
enhance/codemirror
branch
2 times, most recently
from
3112703 to
2e7be1f
Compare
chvp
approved these changes
Sep 4, 2023
jorg-vr
added
deploy naos
jorg-vr
requested changes
Sep 11, 2023
|
|
||
| // A custom theme for CodeMirror that applies the same CSS as Rouge does, | ||
| // meaning we can use our existing themes. | ||
| const rougeStyle = HighlightStyle.define([ |
There was a problem hiding this comment.
Could this also be used for the papyros code editor? (as it also uses code mirror)
This would greatly improve styling
There was a problem hiding this comment.
Since Papyros sets up its own editor, this is no small task: we would need to either hardcode a "dodona" mode (which isn't nice) or change the API to support configuring the CodeMirror instance used by Papyros (which is a lot of work).
There was a problem hiding this comment.
Can't we make the 'dodona mode' the default for papyros? ANd just make their default styling consistent.
I'll have a look at this at some later point. No need to fix that for this pr
CodeMirror uses the .nv class a lot, meaning a lot of the code will be italicized. Rather than change CodeMirror to use the less specific and less semantic class .n (for names), we remove the italic from the .nv class instead.
niknetniko
force-pushed
the
enhance/codemirror
branch
from
2e7be1f to
2e4cd2b
Compare
jorg-vr
approved these changes
Sep 12, 2023
This was referenced Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request replaces the Ace Editor with CodeMirror (which is a commonly-used text editing component for the web).
While functionally equivalent for end-users, it does have some benefits:
On the other hand, it does need a bit more code to:
Closes #4585 as a side effect.