Replace mysql2 gem with trilogy

[jorg-vr]

This pull request replaces the mysql2 gem with trilogy for database interactions.

This is a drop-in replacement that works flawlessly out of the box.

Part of #5370

[coderabbitai]

Walkthrough

The changes involve updating the database connection settings across multiple files to replace the MySQL adapter with the Trilogy adapter. Specifically, the TEST_DATABASE_URL environment variable in two job sections of the GitHub Actions workflow file is modified. The Gemfile is updated to use the trilogy gem instead of mysql2, and the database configuration file reflects these changes by updating the adapter and connection URL examples. Overall, the modifications ensure that the application interacts with the database using the Trilogy adapter.

Changes

File	Change Summary
.github/workflows/test.yml	Updated TEST_DATABASE_URL from mysql2://... to trilogy://... in jobs ruby and system.
Gemfile	Replaced gem 'mysql2', '~> 0.5.6' with gem 'trilogy', '~> 2.9.0'.
config/database.yml	Changed adapter from mysql2 to trilogy and updated connection URL example accordingly.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (4)

config/database.yml (2)

37-37: Enhance connection URL documentation

While the example is correct, consider adding more comprehensive examples including:

• SSL configuration options
• Connection timeout settings
• Other trilogy-specific parameters

---

Line range hint 1-53: Consider additional security configurations for trilogy

The current security setup using environment variables and Rails credentials is good. However, consider:

1. Documenting any trilogy-specific SSL/TLS configuration options
2. Adding explicit connection timeout settings
3. Implementing connection retry policies

Example configuration additions:

default: &default
  adapter: trilogy
  # Add these trilogy-specific configurations
  ssl_mode: VERIFY_IDENTITY
  connect_timeout: 5
  read_timeout: 10
  retry_count: 3

Gemfile (2)

8-9: Consider database migration strategy and testing

Since this is a fundamental change to the database adapter layer:

1. Ensure comprehensive testing across all database interactions, particularly:
   • Connection pooling behavior
   • Transaction handling
   • Character encoding
   • Prepared statements
   • Connection timeouts and reconnection behavior
2. Plan a careful migration strategy for production:
   • Consider a staged rollout
   • Have a rollback plan ready
   • Monitor for any performance changes
3. Update your deployment documentation to reflect any trilogy-specific configuration requirements

---

8-9: Add database-specific tests for trilogy adapter

Consider adding specific tests to verify trilogy adapter behavior:

1. Add connection pool tests
2. Verify reconnection scenarios
3. Test transaction isolation levels
4. Benchmark performance compared to mysql2

Would you like me to provide example test cases for these scenarios?

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 9b12641 and dd7e12e.

⛔ Files ignored due to path filters (1)

• Gemfile.lock is excluded by !**/*.lock

📒 Files selected for processing (3)

• .github/workflows/test.yml (2 hunks)
• Gemfile (1 hunks)
• config/database.yml (2 hunks)

🔇 Additional comments (4)

config/database.yml (1)

2-2: Verify trilogy adapter compatibility across environments

The adapter change looks correct, but please ensure:

1. All environments have been tested with the new adapter
2. Connection pool settings are appropriate for trilogy
3. Any custom SQL queries are compatible with trilogy

.github/workflows/test.yml (2)

17-17: LGTM! Database URL changes are consistent.

The TEST_DATABASE_URL changes maintain the same connection parameters while only updating the protocol from mysql2:// to trilogy://, which aligns with the PR objective of replacing the mysql2 gem with trilogy.

Also applies to: 85-85

---

Line range hint 20-29: Verify MariaDB compatibility with Trilogy adapter.

While the database URL changes look correct, please ensure that:

1. The Trilogy adapter is fully compatible with MariaDB
2. The existing MariaDB health checks (healthcheck.sh --su-mysql --connect --innodb_initialized) remain valid with Trilogy

Also applies to: 88-97

Gemfile (1)

8-9: Verify trilogy gem compatibility and version constraints

A few considerations for this database adapter change:

1. Ensure trilogy gem is fully compatible with Rails 7.2.2 and other database-related gems in your stack (like delayed_job_active_record, counter_culture).
2. The version constraint ~> 2.9.0 is appropriate as it allows patch updates while maintaining stability.
3. Consider adding comments about any specific configuration requirements for trilogy in production environments.