Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow using use tag in sanitized html #5984

Merged
merged 2 commits into from
Dec 4, 2024
Merged

Allow using use tag in sanitized html #5984

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ddcc08b
Add failing test
jorg-vr Dec 3, 2024
00cea2c
Safely allow use
jorg-vr Dec 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/helpers/application_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ def markdown_unsafe(source)
def sanitize(html)
@tags ||= Rails::Html::SafeListSanitizer.allowed_tags.to_a +
%w[table thead tbody tr td th colgroup col style summary details img] +
%w[svg g style circle line rect path polygon polyline text defs]
%w[svg g style circle line rect path polygon polyline text defs use]
@attributes ||= Rails::Html::SafeListSanitizer.allowed_attributes.to_a +
%w[style target data-bs-toggle data-parent data-tab data-line data-element id] +
%w[viewBox width height version style class transform id x y rx ry x1 y1 x2 y2 d points fill stroke stroke-width stroke-dasharray cx cy r font-size font-family font-weight font-variant textLength writing-mode glyph-orientation-vertical text-orientation color]
Expand Down
7 changes: 6 additions & 1 deletion test/helpers/application_helper_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,14 +74,17 @@ class ApplicationHelperTest < ActiveSupport::TestCase
<svg>
<script>alert(1)</script>
<use xlink:href="javascript:alert(1)"/>
<use xlink:href="test.svg"/>
<use href="javascript:alert(1)"/>
<use href="test.svg"/>
</svg>
<p>Hello
HTML
clean_html = sanitize dirty_html

assert_no_match(/<script>/, clean_html)
assert_no_match(/onerror/, clean_html)
assert_no_match(/<use/, clean_html)
assert_no_match(/xlink:href/, clean_html)
assert_match(/<p>Hello/, clean_html)
end

Expand Down Expand Up @@ -130,6 +133,8 @@ class ApplicationHelperTest < ActiveSupport::TestCase
<polygon class="border" points="0,1 -0.5773,0 0,-1 0.5773,0 0,1" fill="none"></polygon>
</g>
</defs>
<use xlink:href="#diamond" x="50" y="50" fill="red"></use>
<use href="#diamond" x="50" y="50" fill="red"></use>
<g id="group1" transform="translate(50,50)">
<circle cx="0" cy="0" r="40" fill="none"></circle>
<line class="test" x1="0" y1="0" x2="0" y2="-40"></line>
Expand Down
Loading