#2846 Type error when importing docx in CJS file with TypeScript modu…

[dolanmiu]

…leResolution set to node16

Resolves: #2846

@danewilson can you confirm if this is the correct change? Will this still work for UMD and IIFE?

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (df99f96) to head (59cb53c).
Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff            @@
##            master     #2883   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          286       286           
  Lines         8370      8370           
  Branches      1400      1400           
=========================================
  Hits          8370      8370           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[danewilson]

Unfortunately this isn't quite right, you need a separate declaration file for CJS and ESM. You can check this yourself by running npx @arethetypeswrong/cli -P . or npx publint in your project directory.

There's an open issue for the tool you're using to generate the declaration file discussing this exact issue. I'd recommend doing something like this but with this variation because you're using "type": "module".

Hope that helps.

[dolanmiu]

Thanks.

Now it passes for publint and @arethetypeswrong/cli

C:\Users\Dolan\Documents\Git\docx>npx @arethetypeswrong/cli -P .

docx v9.1.0

Build tools:
- [email protected]
- vite@^6.0.1

 No problems found 🌟


┌───────────────────┬──────────┐
│                   │ "docx"   │
├───────────────────┼──────────┤
│ node10            │ 🟢        │
├───────────────────┼──────────┤
│ node16 (from CJS) │ 🟢 (CJS)  │
├───────────────────┼──────────┤
│ node16 (from ESM) │ 🟢 (ESM)  │
├───────────────────┼──────────┤
│ bundler           │ 🟢        │
└───────────────────┴──────────┘

C:\Users\Dolan\Documents\Git\docx>npx publint   
docx lint results:
All good!