Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DIOS-4818 bump v2.0 #95

Merged
merged 45 commits into from
Aug 21, 2024
Merged

DIOS-4818 bump v2.0 #95

merged 45 commits into from
Aug 21, 2024

Conversation

mshaa92
Copy link
Contributor

@mshaa92 mshaa92 commented May 28, 2024

Updated to v2.0. Note that you should place System.env variables on your machine for JFROG. Find the credentials needed in settings.gradle for internal repo usage (Jfrog). The artifact used is 2.0.0-SNAPSHOT-2910-b9216bf6. The CI will keep failing till we have a maven published v2.0.

mshaa92 added 12 commits May 24, 2024 21:28
… connection & subscription

Signed-off-by: Mostafa Ashraf <[email protected]>
…roid-viewer into feature/DIOS-4818_bump_v1.9.0_signed

# Conflicts:
#	gradle/libs.versions.toml
#	rtscomponentkit/src/main/java/io/dolby/rtscomponentkit/data/SingleStreamListener.kt
#	rtscomponentkit/src/main/java/io/dolby/rtscomponentkit/data/multistream/MultiStreamListener.kt
#	rtscomponentkit/src/main/java/io/dolby/rtscomponentkit/data/multistream/MultiStreamingRepository.kt
Signed-off-by: Mostafa Ashraf <[email protected]>
Signed-off-by: Mostafa Ashraf <[email protected]>
mshaa92 added 15 commits May 28, 2024 16:03
Signed-off-by: Mostafa Ashraf <[email protected]>
Signed-off-by: Mostafa Ashraf <[email protected]>
Signed-off-by: Mostafa Ashraf <[email protected]>
Signed-off-by: Mostafa Ashraf <[email protected]>
Signed-off-by: Mostafa Ashraf <[email protected]>
@RameshDPrasad RameshDPrasad force-pushed the feature/DIOS-4818_bump_v2.0 branch from 32f6beb to d5529db Compare June 18, 2024 19:39
app/build.gradle Outdated
@@ -35,7 +35,7 @@ android {

defaultConfig {
applicationId "io.dolby.rtsviewer"
minSdk 25
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use an alternative to DateTimeFormatter? The SDK actually does support minSDK 25

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done used threeten as we used before

Copy link
Contributor

@mupatt-dolby mupatt-dolby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@RameshDPrasad RameshDPrasad merged commit 02e3b3e into main Aug 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants