Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: multisource support in publisher #236

Merged
merged 17 commits into from
Jan 10, 2023
Merged

feat: multisource support in publisher #236

merged 17 commits into from
Jan 10, 2023

Conversation

jackshen
Copy link
Contributor

@jackshen jackshen commented Jan 9, 2023

Issue: #147

Description

In this PR, you can:

  • Add new cameras, up to a limit of 4 total (incl. screen shares)
  • Add multiple screen shares, up to a limit of 4 total (incl. devices)
  • The videos will be displayed in a 1/2/3/4 grid layout
  • You can change settings on a per-source basis, incl. name (N.B. name is only saved locally for now)

Code changes

  • refactored publisher app to use useMultiMediaDevices hook
  • refactored state and logic flowin publisher app to support multisource
  • enabled adding multiple cameras
  • added basic device selector
  • updated video settings onto a per-stream basis
  • styled grid view format for multiple videos in publisher

@jackshen
feat: multisource support in publisher
5d90b10 
- refactored publisher app to use useMultiMediaDevices hook
- refactored state and logic flowin publisher app to support multisource
- enabled adding multiple cameras
- added basic device selector
- updated video settings onto a per-stream basis
- styled grid view format for multiple videos in publisher
@vincentsong vincentsong linked an issue Jan 9, 2023 that may be closed by this pull request
[Publisher] Show different sources in grid view #147
Closed
2 tasks
vincentsong
vincentsong reviewed Jan 9, 2023
View reviewed changes
apps/publisher/src/app.tsx Show resolved Hide resolved
apps/publisher/src/app.tsx Show resolved Hide resolved
apps/publisher/src/app.tsx Show resolved Hide resolved
libs/drawer/src/index.tsx Show resolved Hide resolved
libs/drawer/src/index.tsx Show resolved Hide resolved
@vishalkharge
Copy link
Contributor

@jackshen

Here are some basic functional issues observed on this PR:

  1. There is no way to close the screen share view or additional camera view
  2. For screen share view, resolution setting dropdown has undefined value
  3. For camera view, microphone and camera toggle buttons are missing
  4. For screen view, close/stop toggle buttons are missing
  5. Error message 'Failed to execute 'setRemoteDescription' on 'RTCPeerConnection': Failed to set remote answer sdp: Called in wrong state: stable' is shown when publisher goes live.

@jackshen
Copy link
Contributor Author

jackshen commented Jan 9, 2023 •
edited
Loading

@jackshen

Here are some basic functional issues observed on this PR:

  1. There is no way to close the screen share view or additional camera view
  1. For screen view, close/stop toggle buttons are missing

1 and 4 will be handled in #195

vincentsong
vincentsong previously approved these changes Jan 10, 2023
View reviewed changes
@jackshen jackshen mentioned this pull request Jan 10, 2023
Open
@jackshen jackshen merged commit 87e8075 into int-issue-145-multisources Jan 10, 2023
@jackshen jackshen deleted the issue-147-publisher-app-multi-source-grid-layout branch January 10, 2023 08:03
vishalkharge added a commit that referenced this pull request Jan 19, 2023
@vishalkharge @vincentsong
@jackshen @adamlorek-mq @dubeyShivank @dzfill
Add app or businsess specific steps (#249)
f59f71c 
* publisher done

* chore: moved useViewer types and utils to their own files

* chore: moved usePublisher types to own file

* Issue 177 use multi media devices (#190)

* Disable simulcast when stream is done (#168)

* Readme copyedits

* Introduce contributing.md file (#164)

* solved #174 (#176)

* get stream name from ENV first

* Volume slider & change device event listener (#165)

* introduce reducer and volume slider

* finish volume slider for multiple sources + fix device bugs

* CR fixes & bug fixes

* Fixed default volume level to 50%

Co-authored-by: Adam Lorek <[email protected]>
Co-authored-by: Kharge <[email protected]>

* Delete dependabot.yml

* solved #180 (#185)

* solved #178 (#187)

* init

* isolated use media device

* use multiple media devices

* clear

* CR fixes

* bug fixes

Co-authored-by: Shivank Dubey <[email protected]>
Co-authored-by: dzfill <[email protected]>
Co-authored-by: Vincent Song <[email protected]>
Co-authored-by: Adam Lorek <[email protected]>
Co-authored-by: Kharge <[email protected]>

* E2E Test framework enhancement (#199)

* E2E Test framework enhancement

* Removed the eslintrc1 file

* Add yarn.lock

* Added test-id for the required components

* Addressed review comments

* Issue 203 remove start stop button (#204)

* chore: remove start/stop button and just start viewer upon render

* fix: removed start/stop button

* chore: removed unused imports and console log

* Issue 188 use viewer multiple sources (#197)

* feat: support statistics for multiple sources in viewer hook

* feat: support layers for multiple sources in viewer hook

* chore: removed console logs

* VP9 isn't an option with Simulcast just yet, remove it from the list again (#213)

* Issue 207 add viewer waiting room scenarios (#212)

- Add viewer waiting room scenarios
- Added Publisher Invite Viewers Link Verification scenario

* Issue 214 text input component (#215)

Issue:
#214

### Description

Created dark-mode text input as per
[Figma](https://www.figma.com/file/MyQjNaOOvrMcNLDpCQOxxi/Dolby.io-%2F-Product-Apps%C2%A0%E2%80%93-Components?node-id=26%3A4125&t=hkydTsshlV9IdX28-0),
for use in
#206

* fixed #205  Stream name in the invitation link always change (#217)

The stream name for the viewer app only changes when the user refreshes
the page. It should keep the same value in all other conditions.

* useLocalFiles hook & video view with src (#193)

Co-authored-by: Adam Lorek <[email protected]>
Co-authored-by: wenfeng song <[email protected]>

* Issue 181 use local files (#224)

Co-authored-by: Adam Lorek <[email protected]>

* Issue 221 tabs component (#222)

Issue:
#221

### Description

Created dark-mode tabs as per
[Figma](https://www.figma.com/file/mpGO2yc1EBeDKgcvhmm5CA/Dolby.io-%2F-Real-time-Streaming-%E2%80%93-MVP?node-id=6274%3A20883&t=gdr2RFo1MC7WQ4ot-0)

* Fix viewer invite URL (#225)

Fix viewer invite URL
[Viewer app base url for deployment preview of pull
request](#220)

* Issue 184 add settings UI for each source (#206)

Issue:
#184

### Description

Provide each source with the settings UI drawer

**Not included in this PR**

- Business logic for per-stream publisher settings (only the UI)
- Logic for setting/getting stream source names in publisher
- Logic for setting/getting stream quality in viewer

**TBD**

- Update tests: remove old settings tests

Co-authored-by: Kharge <[email protected]>

* Issue 146 enhance statistics UI for each source (#232)

Issue:
#146

### Description

Provide each source with the statistics UI popover

* Issue 230 E2E Test: Test Config independent of tool (#234)

Make test config independent of any tool.

* Issue 227  E2E Test: ReadMe File  (#230)

ReadMe for E2E Test which contains:
- Prerequisites
- Installation and setup
- Test Execution and Report

* feat: multisource support in publisher (#236)

Issue:
#147

### Description

In this PR, you can:

- Add new cameras, up to a limit of 4 total (incl. screen shares)
- Add multiple screen shares, up to a limit of 4 total (incl. devices)
- The videos will be displayed in a 1/2/3/4 grid layout
- You can change settings on a per-source basis, incl. name (N.B. name
is only saved locally for now)

### Code changes

- refactored publisher app to use useMultiMediaDevices hook
- refactored state and logic flowin publisher app to support multisource
- enabled adding multiple cameras
- added basic device selector
- updated video settings onto a per-stream basis
- styled grid view format for multiple videos in publisher

* Add app or businsess specific steps

Co-authored-by: wenfeng song <[email protected]>
Co-authored-by: Jack Shen <[email protected]>
Co-authored-by: adamlorek-mq <[email protected]>
Co-authored-by: Shivank Dubey <[email protected]>
Co-authored-by: dzfill <[email protected]>
Co-authored-by: Adam Lorek <[email protected]>
vincentsong added a commit that referenced this pull request Feb 24, 2023
@vincentsong @jackshen
@adamlorek-mq @dubeyShivank @dzfill @vishalkharge @dependabot
[Feature] Multi-Sources Support (#226)
aae1c75 
* publisher done

* chore: moved useViewer types and utils to their own files

* chore: moved usePublisher types to own file

* Issue 177 use multi media devices (#190)

* Disable simulcast when stream is done (#168)

* Readme copyedits

* Introduce contributing.md file (#164)

* solved #174 (#176)

* get stream name from ENV first

* Volume slider & change device event listener (#165)

* introduce reducer and volume slider

* finish volume slider for multiple sources + fix device bugs

* CR fixes & bug fixes

* Fixed default volume level to 50%

Co-authored-by: Adam Lorek <[email protected]>
Co-authored-by: Kharge <[email protected]>

* Delete dependabot.yml

* solved #180 (#185)

* solved #178 (#187)

* init

* isolated use media device

* use multiple media devices

* clear

* CR fixes

* bug fixes

Co-authored-by: Shivank Dubey <[email protected]>
Co-authored-by: dzfill <[email protected]>
Co-authored-by: Vincent Song <[email protected]>
Co-authored-by: Adam Lorek <[email protected]>
Co-authored-by: Kharge <[email protected]>

* E2E Test framework enhancement (#199)

* E2E Test framework enhancement

* Removed the eslintrc1 file

* Add yarn.lock

* Added test-id for the required components

* Addressed review comments

* Issue 203 remove start stop button (#204)

* chore: remove start/stop button and just start viewer upon render

* fix: removed start/stop button

* chore: removed unused imports and console log

* Issue 188 use viewer multiple sources (#197)

* feat: support statistics for multiple sources in viewer hook

* feat: support layers for multiple sources in viewer hook

* chore: removed console logs

* VP9 isn't an option with Simulcast just yet, remove it from the list again (#213)

* Issue 207 add viewer waiting room scenarios (#212)

- Add viewer waiting room scenarios
- Added Publisher Invite Viewers Link Verification scenario

* Issue 214 text input component (#215)

Issue:
#214

### Description

Created dark-mode text input as per
[Figma](https://www.figma.com/file/MyQjNaOOvrMcNLDpCQOxxi/Dolby.io-%2F-Product-Apps%C2%A0%E2%80%93-Components?node-id=26%3A4125&t=hkydTsshlV9IdX28-0),
for use in
#206

* fixed #205  Stream name in the invitation link always change (#217)

The stream name for the viewer app only changes when the user refreshes
the page. It should keep the same value in all other conditions.

* useLocalFiles hook & video view with src (#193)

Co-authored-by: Adam Lorek <[email protected]>
Co-authored-by: wenfeng song <[email protected]>

* Issue 181 use local files (#224)

Co-authored-by: Adam Lorek <[email protected]>

* Issue 221 tabs component (#222)

Issue:
#221

### Description

Created dark-mode tabs as per
[Figma](https://www.figma.com/file/mpGO2yc1EBeDKgcvhmm5CA/Dolby.io-%2F-Real-time-Streaming-%E2%80%93-MVP?node-id=6274%3A20883&t=gdr2RFo1MC7WQ4ot-0)

* Fix viewer invite URL (#225)

Fix viewer invite URL
[Viewer app base url for deployment preview of pull
request](#220)

* Issue 184 add settings UI for each source (#206)

Issue:
#184

### Description

Provide each source with the settings UI drawer

**Not included in this PR**

- Business logic for per-stream publisher settings (only the UI)
- Logic for setting/getting stream source names in publisher
- Logic for setting/getting stream quality in viewer

**TBD**

- Update tests: remove old settings tests

Co-authored-by: Kharge <[email protected]>

* Issue 146 enhance statistics UI for each source (#232)

Issue:
#146

### Description

Provide each source with the statistics UI popover

* Issue 230 E2E Test: Test Config independent of tool (#234)

Make test config independent of any tool.

* Issue 227  E2E Test: ReadMe File  (#230)

ReadMe for E2E Test which contains:
- Prerequisites
- Installation and setup
- Test Execution and Report

* feat: multisource support in publisher (#236)

Issue:
#147

### Description

In this PR, you can:

- Add new cameras, up to a limit of 4 total (incl. screen shares)
- Add multiple screen shares, up to a limit of 4 total (incl. devices)
- The videos will be displayed in a 1/2/3/4 grid layout
- You can change settings on a per-source basis, incl. name (N.B. name
is only saved locally for now)

### Code changes

- refactored publisher app to use useMultiMediaDevices hook
- refactored state and logic flowin publisher app to support multisource
- enabled adding multiple cameras
- added basic device selector
- updated video settings onto a per-stream basis
- styled grid view format for multiple videos in publisher

* Local file UI (#247)

* Local/Remote file UI

* fixed e2e test

* added netilify _headers file

* added netlify _redirects

* fixed netlify _redirects

* try dolby cors

* removed stream remote file

* fixed e2e test

* removed unused

* Added test-id for local file view

Co-authored-by: Kharge <[email protected]>

* Add app or businsess specific steps (#249)

* publisher done

* chore: moved useViewer types and utils to their own files

* chore: moved usePublisher types to own file

* Issue 177 use multi media devices (#190)

* Disable simulcast when stream is done (#168)

* Readme copyedits

* Introduce contributing.md file (#164)

* solved #174 (#176)

* get stream name from ENV first

* Volume slider & change device event listener (#165)

* introduce reducer and volume slider

* finish volume slider for multiple sources + fix device bugs

* CR fixes & bug fixes

* Fixed default volume level to 50%

Co-authored-by: Adam Lorek <[email protected]>
Co-authored-by: Kharge <[email protected]>

* Delete dependabot.yml

* solved #180 (#185)

* solved #178 (#187)

* init

* isolated use media device

* use multiple media devices

* clear

* CR fixes

* bug fixes

Co-authored-by: Shivank Dubey <[email protected]>
Co-authored-by: dzfill <[email protected]>
Co-authored-by: Vincent Song <[email protected]>
Co-authored-by: Adam Lorek <[email protected]>
Co-authored-by: Kharge <[email protected]>

* E2E Test framework enhancement (#199)

* E2E Test framework enhancement

* Removed the eslintrc1 file

* Add yarn.lock

* Added test-id for the required components

* Addressed review comments

* Issue 203 remove start stop button (#204)

* chore: remove start/stop button and just start viewer upon render

* fix: removed start/stop button

* chore: removed unused imports and console log

* Issue 188 use viewer multiple sources (#197)

* feat: support statistics for multiple sources in viewer hook

* feat: support layers for multiple sources in viewer hook

* chore: removed console logs

* VP9 isn't an option with Simulcast just yet, remove it from the list again (#213)

* Issue 207 add viewer waiting room scenarios (#212)

- Add viewer waiting room scenarios
- Added Publisher Invite Viewers Link Verification scenario

* Issue 214 text input component (#215)

Issue:
#214

### Description

Created dark-mode text input as per
[Figma](https://www.figma.com/file/MyQjNaOOvrMcNLDpCQOxxi/Dolby.io-%2F-Product-Apps%C2%A0%E2%80%93-Components?node-id=26%3A4125&t=hkydTsshlV9IdX28-0),
for use in
#206

* fixed #205  Stream name in the invitation link always change (#217)

The stream name for the viewer app only changes when the user refreshes
the page. It should keep the same value in all other conditions.

* useLocalFiles hook & video view with src (#193)

Co-authored-by: Adam Lorek <[email protected]>
Co-authored-by: wenfeng song <[email protected]>

* Issue 181 use local files (#224)

Co-authored-by: Adam Lorek <[email protected]>

* Issue 221 tabs component (#222)

Issue:
#221

### Description

Created dark-mode tabs as per
[Figma](https://www.figma.com/file/mpGO2yc1EBeDKgcvhmm5CA/Dolby.io-%2F-Real-time-Streaming-%E2%80%93-MVP?node-id=6274%3A20883&t=gdr2RFo1MC7WQ4ot-0)

* Fix viewer invite URL (#225)

Fix viewer invite URL
[Viewer app base url for deployment preview of pull
request](#220)

* Issue 184 add settings UI for each source (#206)

Issue:
#184

### Description

Provide each source with the settings UI drawer

**Not included in this PR**

- Business logic for per-stream publisher settings (only the UI)
- Logic for setting/getting stream source names in publisher
- Logic for setting/getting stream quality in viewer

**TBD**

- Update tests: remove old settings tests

Co-authored-by: Kharge <[email protected]>

* Issue 146 enhance statistics UI for each source (#232)

Issue:
#146

### Description

Provide each source with the statistics UI popover

* Issue 230 E2E Test: Test Config independent of tool (#234)

Make test config independent of any tool.

* Issue 227  E2E Test: ReadMe File  (#230)

ReadMe for E2E Test which contains:
- Prerequisites
- Installation and setup
- Test Execution and Report

* feat: multisource support in publisher (#236)

Issue:
#147

### Description

In this PR, you can:

- Add new cameras, up to a limit of 4 total (incl. screen shares)
- Add multiple screen shares, up to a limit of 4 total (incl. devices)
- The videos will be displayed in a 1/2/3/4 grid layout
- You can change settings on a per-source basis, incl. name (N.B. name
is only saved locally for now)

### Code changes

- refactored publisher app to use useMultiMediaDevices hook
- refactored state and logic flowin publisher app to support multisource
- enabled adding multiple cameras
- added basic device selector
- updated video settings onto a per-stream basis
- styled grid view format for multiple videos in publisher

* Add app or businsess specific steps

Co-authored-by: wenfeng song <[email protected]>
Co-authored-by: Jack Shen <[email protected]>
Co-authored-by: adamlorek-mq <[email protected]>
Co-authored-by: Shivank Dubey <[email protected]>
Co-authored-by: dzfill <[email protected]>
Co-authored-by: Adam Lorek <[email protected]>

* Issue 194 add camera popover (#257)

* Added camera preview for adding camera and microphone modal

* refine the camera selection

* cancel previous run when new commits pushed

* cancel previous run when new commits pushed

* cancel previous run when new commits pushed

* added comment

* added test-id back

* Issue 252 BDD scenarios : camera source streaming (#260)

* Add app or businsess specific steps

* Fixed the unsupported resolution

* Set viewerURL when publisher app is not opened

* Addressed review comments

* BDD Scenarios - Camera Only Streaming

* Addressed Review Comments

* Issue 191 viewer app multi source grid layout (#261)

* feat: multi source in viewer with reprojection of main streams

* fix: updated max sources to 4

* fix: implemented suggestions

* fix: rename variables, implemented retry-catch for viewer reconnections

* fix: various bugfixes

* fix: addressed comments

* test: disabled tests

* test: disabled tests

* test: fixed tests

* fix: only handle error on reconnect catch

* chore: renamed variables

* Issue 271 reimplement local file management in publisher (#272)

* refactor: reimplemented local file streams in publisher

* chore: renamed hook to to more semantic name, removed deprecated hook

* test: updated test-ids

* test: temporarily disabled test

* chore: fixed comment

* test: temporarily disabled test

* Issue 241 refactor stream state management in publisher (#273)

* refactor: refactored video information state implementation in publisher

* refactor: redid file upload state

* test: reenabled test

* test: added missing test spex

* Revert "test: added missing test spex"

This reverts commit 41383a0.

* chore: undid unnecessary tsconfig reference

* test: fix simulcast test

* fix: resolved apply constraints bug

* fix: simulcast on by default when codec is h264

* Revert "Issue 241 refactor stream state management in publisher (#273)" (#278)

This reverts commit e6c8ccd.

* Issue 241 refactor publisher streams states (#279)

* refactor: refactored video information state implementation in publisher

* refactor: redid file upload state

* test: reenabled test

* test: added missing test spex

* Revert "test: added missing test spex"

This reverts commit 41383a0.

* chore: undid unnecessary tsconfig reference

* test: fix simulcast test

* fix: resolved apply constraints bug

* fix: simulcast on by default when codec is h264

* fix: removed unused method, resolved add device bug

* refactor: moved all state into usePublisher hook

* fix: show multisource badge only when more than one is active

* fix: temporary change to be undone in #195

* fix: local state for all live, automatically livestream new sources

* fix: ref to state in useViewer callback, solved unable to unproject

* chore: removed unused hook

* test: updated datetime regex

* fix: additional devices can't change resolution

* fix: better reset mediastream in device preview

* fix: hide resolution for local file

* Issue 253 bdd scenarios screen sharing (#280)

* Screen Sharing Scenarios - Part 1

* Screen Sharing Scenarios - Part 1

* Screen Sharing Scenarios - Part 2

* Screen View Tests

* Fixed failed workflow

* Fixed failed scenarios

* Updated the stats data read logic

* Addressed review comments

* Fixed import issues

* Removed commented code

* Issue 195 publisher and viewer per video controls (#281)

* feat: toggle audio, video, playback, start/stop live on per-video basis

* fix: moved red dot indicator on top of video

* fix: only show toggle playback if media type is local file

* feat: better placeholder when streaming no video

* feat: remove in publisher

* feat: control bar in viewer

* feat: toggle audio, video, playback in viewer

* feat: fullscreen in viewer

* refactor: video controls

* refactor: video controls in publisher

* feat: publisher video controls for local file

* feat: volume slider

* test: updated test locator

* fix: fixed conditional

* test: disabled all tests lmao

* Update readme with multi screen (#276)

* update spec with multi-source

* Split read me into two sections

* Issue 241 refactor stream state management in publisher (#273)

* refactor: refactored video information state implementation in publisher

* refactor: redid file upload state

* test: reenabled test

* test: added missing test spex

* Revert "test: added missing test spex"

This reverts commit 41383a0.

* chore: undid unnecessary tsconfig reference

* test: fix simulcast test

* fix: resolved apply constraints bug

* fix: simulcast on by default when codec is h264

* Revert "Issue 241 refactor stream state management in publisher (#273)" (#278)

This reverts commit e6c8ccd.

* Fix layout style

* Add in local file

* Update features list

* Issue 241 refactor publisher streams states (#279)

* refactor: refactored video information state implementation in publisher

* refactor: redid file upload state

* test: reenabled test

* test: added missing test spex

* Revert "test: added missing test spex"

This reverts commit 41383a0.

* chore: undid unnecessary tsconfig reference

* test: fix simulcast test

* fix: resolved apply constraints bug

* fix: simulcast on by default when codec is h264

* fix: removed unused method, resolved add device bug

* refactor: moved all state into usePublisher hook

* fix: show multisource badge only when more than one is active

* fix: temporary change to be undone in #195

* fix: local state for all live, automatically livestream new sources

* fix: ref to state in useViewer callback, solved unable to unproject

* chore: removed unused hook

* test: updated datetime regex

* fix: additional devices can't change resolution

* fix: better reset mediastream in device preview

* fix: hide resolution for local file

* Reference RTS as Millicast

* Updated read me template

* replace banner image for tokens

* replace all instances of MILLICAST with RTS

* Update name

From stream ID to account ID

Co-authored-by: Vincent Song <[email protected]>

* Update more read me files and remove Millicast references

* Add env.example

* yarn nx format

* Update read me based on Customer 0 feedback (#211)

* Update read me based on Customer 0 feedback

* Add some links

* nx format

* Bump ua-parser-js from 0.7.32 to 0.7.33 (#270)

Bumps [ua-parser-js](https://github.com/faisalman/ua-parser-js) from 0.7.32 to 0.7.33.
- [Release notes](https://github.com/faisalman/ua-parser-js/releases)
- [Changelog](https://github.com/faisalman/ua-parser-js/blob/master/changelog.md)
- [Commits](faisalman/ua-parser-js@0.7.32...0.7.33)

---
updated-dependencies:
- dependency-name: ua-parser-js
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update permissions screenshot

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Jack Shen <[email protected]>
Co-authored-by: Vincent Song <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* only show close button for each source when there are more than 1 sources (#298)

* Feedback on testing (#293)

* Feedback on testing

* Format

* Update read me with .env file

* show video or audio statistics (#304)

* Image link fixed

* Image size fixed

* [Bugfix] Viewer video freeze after remove publisher source (#308)

* use array push instead of object spreading

* remove log

* style: fixed safari styles (#303)

* style: fixed safari styles

* style: changed width styles

* style: width update

* fix: typo

* fix: reproject and reselect layer when quality options change (#309)

* filtered invlalid statistics in publisher (#312)

* use js function that works in safari (#317)

* issue 307 swap main and secondary videos instead of mirroring in viewer (#310)

* feat: swap main and secondary videos instead of mirroring in viewer

* style: secondary stream heights

* feat: unproject and reproject

* feat: don't show side panel if no main stream id

* chore: implemented suggestions

* fix: unproject

* feat: decide whether to project to main stream in active event

* fix: not properly changing main stream when removed

* remove device change event handler (#320)

* Issue 326 stream stats in viewer regression (#327)

* fix: regression issue with statistics, use stats by main stream layers

* chore: no need to handle statistics for every video

* Issue 283 fix tests: Fix camera preview and streaming test failures (#305)

* fixed publisher preview scenarios

* Updated Camera Only Streaming Tests

* Fix reading stats data issue

* Added Sleep

* Fixed the STREAM_NAME env issue

* Added more scenarios

* Added more tests

* Fixed test data

* Removed the tag

* Fixed publisher-camera-stream and publisher-screen-preview tests

* Added screen share streaming scenarios

* Updated tests as per new viewer layout

* Fixed the package name in yarn.lock

* Fixed bdd scenario step

* Fix worflow parallel issue

* Added source-map-support for proper stacktrace

* Added retry for failed tests

* Removed the source map imprt

* Optimize CI/CD test execution time

* Fixed prettier formating

* Added more screen share scenarios

* feat: individual video playback control states in viewer app (#322)

* feat: individual video playback control states in viewer app

* fix: do not handle playback state

* chore: defined type for hook

* fix: removed old type

* chore: added comment

* fix: magnitude and prefixing

* test: fixed magnitude prefixes

* fix: handle and update quality options for main stream only (#329)

* fix: handle projecting empty audio tracks (#330)

* chore: removed deprecated dispatch in useViewer (#336)

* Issue 301 control bar tweaks in publisher and viewer (#331)

* fix: control bar tweaks in publisher and viewer

* fix: settings popover placement

* test: fixed test

* fix: implemented suggestion

* chore: changed conditional order

* Issue 254 bdd scenarios local file and multi source (#332)

* Added local file and multisource tests

* Uncommented stats verification

* Updated the cicd targets

* Fix broken link

* Issue 243 hidden viewer link and optimize tests (#340)

* Add hidden viewer link

* Updated the tooltip

* removed the stream name env

* Removed cucumber parallel option

* Fixed lint issue

* Upgrade playwright version

* Addressed review comments

* Issue 338 update audio toggle behaviour (#342)

* fix: remove unused playback states, persist volume value when unmuting

* chore: removed console log

* fix: logic issue

* Issue 339 update quality options when changing simulcast (#341)

* fix: update quality when no active streams

* test: fixed test

* Fixed test failures

---------

Co-authored-by: Kharge <[email protected]>

* Issue 343 Github - Execute Test Jobs In Parallel  (#344)

* Created parallel test jobs

* Fixed workflow failure

* removed needs from lint job

* Resuable Workflow

* Fixed deploy job dependency

* Fixed typo issue

* Added composite setup action

* Fixed composite action

* Passing data to workflow and actions

* Fixed lint issue

* Passed correct suite name

* Fixed passing secrets

* Addressed review comments

* Addressed the review comments

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Jack Shen <[email protected]>
Co-authored-by: adamlorek-mq <[email protected]>
Co-authored-by: Shivank Dubey <[email protected]>
Co-authored-by: dzfill <[email protected]>
Co-authored-by: Adam Lorek <[email protected]>
Co-authored-by: Kharge <[email protected]>
Co-authored-by: vishalkharge <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincentsong vincentsong vincentsong approved these changes

@vishalkharge vishalkharge Awaiting requested review from vishalkharge

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Publisher] Show different sources in grid view
3 participants
@jackshen @vishalkharge @vincentsong