Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance Improvements for Hide Shorts #6

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Performance Improvements for Hide Shorts #6

wants to merge 6 commits into from

Conversation

ganeshh123
Copy link

@ganeshh123 ganeshh123 commented May 17, 2022 •
edited
Loading

Some things I have attempted to do to improve the "Hide Shorts" function:

  • Remove Loading Spinners when videos load under them and fix the grid layout when videos get removed
  • Only listen for Mutation events for specific elements in Watch & Channel pages
  • Only process the video items if the mutation event included the insertion of new relevant items into the DOM (ignoring stuff like mouse movements)
    Would be good if you could give it a thorough test, and feel free to change the code style and structure to your liking.

@ganeshh123 ganeshh123 mentioned this pull request May 17, 2022
Open
@ganeshh123 ganeshh123 changed the title Performance Improvements Performance Improvements for Hide Shorts May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ganeshh123