Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regenerated pelorus-operator with new operator-sdk version #1130

Merged
merged 1 commit into from
May 20, 2024
Merged

Regenerated pelorus-operator with new operator-sdk version #1130

merged 1 commit into from
May 20, 2024

Conversation

mpryc
Copy link
Collaborator

@mpryc mpryc commented Apr 17, 2024 •
edited
Loading

Updated operator with new operator-sdk version 1.33.

Please go the the Preview tab and select the appropriate template for your PR:

@openshift-ci openshift-ci bot requested review from etsauer and weshayutin April 17, 2024 13:20
@etsauer
Copy link
Collaborator

etsauer commented Apr 17, 2024

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 17, 2024
@etsauer etsauer mentioned this pull request Apr 17, 2024
Closed
1 task
mateusoliveira43
mateusoliveira43 reviewed Apr 22, 2024
View reviewed changes
pelorus-operator/config/rbac/role.yaml Outdated
name: manager-role
rules:
##
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this removal of permissions ok ❓

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBH I don't know as this is generated by the operator-sdk, so we need to test that operator to see.

@mpryc
Copy link
Collaborator Author

mpryc commented Apr 22, 2024

/retest

@mpryc mpryc force-pushed the regenerate_new branch 2 times, most recently from d1de9ce to d84691b Compare April 22, 2024 13:55
@github-actions GitHub Actions
Copy link

Test images available! 🧪🚀 To test operator with them, run

operator-sdk run bundle \
quay.io/pelorus/rc-pelorus-operator-bundle:vpr1130-9651740 \
--namespace test-pelorus-operator

To clean up environment afterwards, run

operator-sdk cleanup pelorus-operator --namespace test-pelorus-operator

@mpryc
Regenerated pelorus-operator with operator-sdk version 1.33
b2468fe 
Updated operator with new operator-sdk version.

Signed-off-by: Michal Pryc <[email protected]>
@mpryc mpryc requested a review from etsauer April 26, 2024 14:24
@github-actions GitHub Actions
Copy link

Test images available! 🧪🚀 To test operator with them, run

operator-sdk run bundle \
quay.io/pelorus/rc-pelorus-operator-bundle:vpr1130-9a05dd3 \
--namespace test-pelorus-operator

To clean up environment afterwards, run

operator-sdk cleanup pelorus-operator --namespace test-pelorus-operator

@etsauer
Copy link
Collaborator

etsauer commented May 9, 2024

/retest

etsauer
etsauer approved these changes May 9, 2024
View reviewed changes
Copy link
Collaborator

@etsauer etsauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the operator deployment, and it looks good.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented May 9, 2024

@mpryc: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/4.13-e2e-openshift b2468fe link true /test 4.13-e2e-openshift

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

mateusoliveira43
mateusoliveira43 approved these changes May 10, 2024
View reviewed changes
Copy link
Collaborator

@mateusoliveira43 mateusoliveira43 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did not test, but code looks good to me

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented May 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: etsauer, mateusoliveira43

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [etsauer,mateusoliveira43]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mateusoliveira43 mateusoliveira43 mentioned this pull request May 14, 2024
Merged
1 task
@mateusoliveira43 mateusoliveira43 merged commit 32b200e into dora-metrics:master May 20, 2024
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mateusoliveira43 mateusoliveira43 mateusoliveira43 approved these changes

@etsauer etsauer etsauer approved these changes

@weshayutin weshayutin Awaiting requested review from weshayutin

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mpryc @etsauer @mateusoliveira43