Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert exporters to use kubernetes deployments instead of openshift … #1158

Closed
wants to merge 2 commits into from

Conversation

etsauer
Copy link
Collaborator

@etsauer etsauer commented Sep 9, 2024

…deploymentconfigs, which are deprecated

Linked Issues

resolves #1147

Description

  • Converted exporter helm chart to deploy using kubnetes Deployments instead of depcrecated OpenShift DeploymentConfigs
  • Renamed the _deploymentconfig.yaml file to _deployment.yaml
  • Updated helper scripts with changed file name

Testing Instructions

Install operator from PR build, and create a test pelorus CR instance. See that exporters deploy successfully, and that they show up on the "Deployments" page in the web console instead of "DeploymentConfigs".

…deploymentconfigs, which are deprecated

Signed-off-by: Eric Sauer <[email protected]>
Copy link

openshift-ci bot commented Sep 9, 2024

@etsauer: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/4.13-e2e-openshift 388c1b4 link true /test 4.13-e2e-openshift

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@etsauer
Copy link
Collaborator Author

etsauer commented Sep 9, 2024

/approve

Copy link

openshift-ci bot commented Sep 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: etsauer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 9, 2024
@etsauer etsauer closed this Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert exporter DeploymentConfigs to Deployments
1 participant