Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved docs #273

Merged
merged 7 commits into from
Aug 3, 2023
Merged

Improved docs #273

merged 7 commits into from
Aug 3, 2023

Conversation

trag1c
Copy link
Contributor

@trag1c trag1c commented Jul 31, 2023

No description provided.

Copy link
Owner

@dosisod dosisod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @trag1c for opening this PR!

One thing that I haven't documented yet is that the docs/checks.md file is auto-generated from the docstrings for each of the checks. For instance, to change the docs for FURB100, go to the refurb/checks/pathlib/with_suffix.py file and change the docstring there, then run make docs which will build the docs/checks.md file. I will go ahead and document this later tonight.

Other than that everything looks good!

@trag1c trag1c requested a review from dosisod August 2, 2023 20:10
Copy link
Owner

@dosisod dosisod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from my one comment this PR looks good!

refurb/checks/iterable/in_tuple.py Show resolved Hide resolved
@dosisod dosisod merged commit 89f28eb into dosisod:master Aug 3, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants