-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Start of the new user layer: client, daemon, registries #497
Closed
Closed
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| **/.classpath | ||
| **/.dockerignore | ||
| **/.env | ||
| **/.git | ||
| **/.gitignore | ||
| **/.project | ||
| **/.settings | ||
| **/.toolstarget | ||
| **/.vs | ||
| **/.vscode | ||
| **/*.*proj.user | ||
| **/*.dbmdl | ||
| **/*.jfm | ||
| **/azds.yaml | ||
| **/bin | ||
| **/charts | ||
| **/docker-compose* | ||
| **/Dockerfile* | ||
| **/node_modules | ||
| **/npm-debug.log | ||
| **/obj | ||
| **/secrets.dev.yaml | ||
| **/values.dev.yaml | ||
| LICENSE | ||
| README.md |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| # To learn more about .editorconfig see https://aka.ms/editorconfigdocs | ||
|
|
||
| ############################### | ||
| # Core EditorConfig Options # | ||
| ############################### | ||
|
|
||
| root = true | ||
|
|
||
| # All files | ||
| [*] | ||
| indent_style = space | ||
|
|
||
| # Code files | ||
| [*.cs] | ||
| indent_size = 4 | ||
| insert_final_newline = true | ||
| charset = utf-8-bom | ||
|
|
||
| # Dockerfiles | ||
| [Dockerfile] | ||
| indent_size = 2 | ||
|
|
||
| # YAML | ||
| [*.yml] | ||
| indent_size = 2 | ||
|
|
||
| # Scripts | ||
| [*.ps1] | ||
| indent_size = 4 | ||
| insert_final_newline = true | ||
| charset = utf-8-bom |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,73 @@ | ||
| <?xml version="1.0" encoding="utf-8"?> | ||
| <configuration> | ||
| <configSections> | ||
| <sectionGroup name="userSettings" type="System.Configuration.UserSettingsGroup, System, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089" > | ||
| <section name="SteveCadwallader.CodeMaid.Properties.Settings" type="System.Configuration.ClientSettingsSection, System, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089" /> | ||
| </sectionGroup> | ||
| </configSections> | ||
| <userSettings> | ||
| <SteveCadwallader.CodeMaid.Properties.Settings> | ||
| <setting name="Cleaning_ExclusionExpression" serializeAs="String"> | ||
| <value>\.Designer\.cs$||\.Designer\.vb$||\.resx$||\.min\.css$||\.min\.js$||\.generated\.cs$||\.generated\.vb$</value> | ||
| </setting> | ||
| <setting name="Cleaning_InsertEndOfFileTrailingNewLine" serializeAs="String"> | ||
| <value>True</value> | ||
| </setting> | ||
| <setting name="Cleaning_RemoveEndOfFileTrailingNewLine" serializeAs="String"> | ||
| <value>False</value> | ||
| </setting> | ||
| <setting name="Formatting_CommentRunDuringCleanup" serializeAs="String"> | ||
| <value>True</value> | ||
| </setting> | ||
| <setting name="Reorganizing_MemberTypeStructs" serializeAs="String"> | ||
| <value>Structs||7||Structs + Enums + Classes + Interfaces</value> | ||
| </setting> | ||
| <setting name="Reorganizing_MemberTypeConstructors" serializeAs="String"> | ||
| <value>Constructors||1||Constructors</value> | ||
| </setting> | ||
| <setting name="Reorganizing_MemberTypeMethods" serializeAs="String"> | ||
| <value>Methods||6||Methods</value> | ||
| </setting> | ||
| <setting name="Reorganizing_MemberTypeProperties" serializeAs="String"> | ||
| <value>Properties||4||Properties + Indexers</value> | ||
| </setting> | ||
| <setting name="Reorganizing_MemberTypeEnums" serializeAs="String"> | ||
| <value>Enums||7||Structs + Enums + Classes + Interfaces</value> | ||
| </setting> | ||
| <setting name="Reorganizing_MemberTypeDestructors" serializeAs="String"> | ||
| <value>Destructors||8||Destructors</value> | ||
| </setting> | ||
| <setting name="Reorganizing_MemberTypeDelegates" serializeAs="String"> | ||
| <value>Delegates||2||Delegates</value> | ||
| </setting> | ||
| <setting name="Reorganizing_MemberTypeIndexers" serializeAs="String"> | ||
| <value>Indexers||4||Properties + Indexers</value> | ||
| </setting> | ||
| <setting name="Reorganizing_MemberTypeClasses" serializeAs="String"> | ||
| <value>Classes||7||Structs + Enums + Classes + Interfaces</value> | ||
| </setting> | ||
| <setting name="Reorganizing_MemberTypeFields" serializeAs="String"> | ||
| <value>Fields||5||Fields</value> | ||
| </setting> | ||
| <setting name="Reorganizing_MemberTypeInterfaces" serializeAs="String"> | ||
| <value>Interfaces||7||Structs + Enums + Classes + Interfaces</value> | ||
| </setting> | ||
| <setting name="Reorganizing_MemberTypeEvents" serializeAs="String"> | ||
| <value>Events||3||Events</value> | ||
| </setting> | ||
| <setting name="Reorganizing_PerformWhenPreprocessorConditionals" | ||
| serializeAs="String"> | ||
| <value>1</value> | ||
| </setting> | ||
| <setting name="Reorganizing_RunAtStartOfCleanup" serializeAs="String"> | ||
| <value>True</value> | ||
| </setting> | ||
| <setting name="Formatting_CommentWrapColumn" serializeAs="String"> | ||
| <value>120</value> | ||
| </setting> | ||
| <setting name="Formatting_CommentSkipWrapOnLastWord" serializeAs="String"> | ||
| <value>False</value> | ||
| </setting> | ||
| </SteveCadwallader.CodeMaid.Properties.Settings> | ||
| </userSettings> | ||
| </configuration> | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,123 @@ | ||
| # To learn more about .editorconfig see https://aka.ms/editorconfigdocs | ||
|
|
||
| ############################### | ||
| # Core EditorConfig Options # | ||
| ############################### | ||
|
|
||
| # inherited | ||
|
|
||
| ############################### | ||
| # .NET Coding Conventions # | ||
| ############################### | ||
|
|
||
| [*.cs] | ||
|
|
||
| # Organize usings | ||
| dotnet_sort_system_directives_first = true | ||
| # this. preferences | ||
| dotnet_style_qualification_for_field = false:silent | ||
| dotnet_style_qualification_for_property = false:silent | ||
| dotnet_style_qualification_for_method = false:silent | ||
| dotnet_style_qualification_for_event = false:silent | ||
| # Language keywords vs BCL types preferences | ||
| dotnet_style_predefined_type_for_locals_parameters_members = true:silent | ||
| dotnet_style_predefined_type_for_member_access = true:silent | ||
| # Parentheses preferences | ||
| dotnet_style_parentheses_in_arithmetic_binary_operators = always_for_clarity:silent | ||
| dotnet_style_parentheses_in_relational_binary_operators = always_for_clarity:silent | ||
| dotnet_style_parentheses_in_other_binary_operators = always_for_clarity:silent | ||
| dotnet_style_parentheses_in_other_operators = never_if_unnecessary:silent | ||
| # Modifier preferences | ||
| dotnet_style_require_accessibility_modifiers = for_non_interface_members:silent | ||
| dotnet_style_readonly_field = true:suggestion | ||
| # Expression-level preferences | ||
| dotnet_style_object_initializer = true:suggestion | ||
| dotnet_style_collection_initializer = true:suggestion | ||
| dotnet_style_explicit_tuple_names = true:suggestion | ||
| dotnet_style_null_propagation = true:suggestion | ||
| dotnet_style_coalesce_expression = true:suggestion | ||
| dotnet_style_prefer_is_null_check_over_reference_equality_method = true:silent | ||
| dotnet_style_prefer_inferred_tuple_names = true:suggestion | ||
| dotnet_style_prefer_inferred_anonymous_type_member_names = true:suggestion | ||
| dotnet_style_prefer_auto_properties = true:silent | ||
| dotnet_style_prefer_conditional_expression_over_assignment = true:silent | ||
| dotnet_style_prefer_conditional_expression_over_return = true:silent | ||
|
|
||
| ############################### | ||
| # Naming Conventions # | ||
| ############################### | ||
|
|
||
| # Style Definitions | ||
| dotnet_naming_style.pascal_case_style.capitalization = pascal_case | ||
| # Use PascalCase for constant fields | ||
| dotnet_naming_rule.constant_fields_should_be_pascal_case.severity = suggestion | ||
| dotnet_naming_rule.constant_fields_should_be_pascal_case.symbols = constant_fields | ||
| dotnet_naming_rule.constant_fields_should_be_pascal_case.style = pascal_case_style | ||
| dotnet_naming_symbols.constant_fields.applicable_kinds = field | ||
| dotnet_naming_symbols.constant_fields.applicable_accessibilities = * | ||
| dotnet_naming_symbols.constant_fields.required_modifiers = const | ||
|
|
||
| ############################### | ||
| # C# Coding Conventions # | ||
| ############################### | ||
|
|
||
| [*.cs] | ||
|
|
||
| # var preferences | ||
| csharp_style_var_for_built_in_types = true:silent | ||
| csharp_style_var_when_type_is_apparent = true:silent | ||
| csharp_style_var_elsewhere = true:silent | ||
| # Expression-bodied members | ||
| csharp_style_expression_bodied_methods = false:silent | ||
| csharp_style_expression_bodied_constructors = false:silent | ||
| csharp_style_expression_bodied_operators = false:silent | ||
| csharp_style_expression_bodied_properties = true:silent | ||
| csharp_style_expression_bodied_indexers = true:silent | ||
| csharp_style_expression_bodied_accessors = true:silent | ||
| # Pattern matching preferences | ||
| csharp_style_pattern_matching_over_is_with_cast_check = true:suggestion | ||
| csharp_style_pattern_matching_over_as_with_null_check = true:suggestion | ||
| # Null-checking preferences | ||
| csharp_style_throw_expression = true:suggestion | ||
| csharp_style_conditional_delegate_call = true:suggestion | ||
| # Modifier preferences | ||
| csharp_preferred_modifier_order = public,private,protected,internal,static,extern,new,virtual,abstract,sealed,override,readonly,unsafe,volatile,async:suggestion | ||
| # Expression-level preferences | ||
| csharp_prefer_braces = true:silent | ||
| csharp_style_deconstructed_variable_declaration = true:suggestion | ||
| csharp_prefer_simple_default_expression = true:suggestion | ||
| csharp_style_pattern_local_over_anonymous_function = true:suggestion | ||
| csharp_style_inlined_variable_declaration = true:suggestion | ||
|
|
||
| ############################### | ||
| # C# Formatting Rules # | ||
| ############################### | ||
|
|
||
| # New line preferences | ||
| csharp_new_line_before_open_brace = all | ||
| csharp_new_line_before_else = true | ||
| csharp_new_line_before_catch = true | ||
| csharp_new_line_before_finally = true | ||
| csharp_new_line_before_members_in_object_initializers = true | ||
| csharp_new_line_before_members_in_anonymous_types = true | ||
| csharp_new_line_between_query_expression_clauses = true | ||
| # Indentation preferences | ||
| csharp_indent_case_contents = true | ||
| csharp_indent_switch_labels = true | ||
| csharp_indent_labels = flush_left | ||
| # Space preferences | ||
| csharp_space_after_cast = false | ||
| csharp_space_after_keywords_in_control_flow_statements = true | ||
| csharp_space_between_method_call_parameter_list_parentheses = false | ||
| csharp_space_between_method_declaration_parameter_list_parentheses = false | ||
| csharp_space_between_parentheses = false | ||
| csharp_space_before_colon_in_inheritance_clause = true | ||
| csharp_space_after_colon_in_inheritance_clause = true | ||
| csharp_space_around_binary_operators = before_and_after | ||
| csharp_space_between_method_declaration_empty_parameter_list_parentheses = false | ||
| csharp_space_between_method_call_name_and_opening_parenthesis = false | ||
| csharp_space_between_method_call_empty_parameter_list_parentheses = false | ||
| # Wrapping preferences | ||
| csharp_preserve_single_line_statements = true | ||
| csharp_preserve_single_line_blocks = true | ||
|
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| using System.Security.Cryptography.X509Certificates; | ||
|
|
||
| namespace DockerSdk | ||
| { | ||
| internal static class CertificateLoader | ||
| { | ||
| /// <summary> | ||
| /// Loads certificates from a file. | ||
| /// </summary> | ||
| /// <param name="path">The file to load from.</param> | ||
| /// <returns>The resultant collection of certificates.</returns> | ||
| /// <exception cref="CryptographicException">The file did not represent a valid certificate.</exception> | ||
| public static X509Certificate2Collection Load(string path) | ||
| { | ||
| var collection = new X509Certificate2Collection(); | ||
| collection.Import(path); | ||
| return collection; | ||
| } | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Configuration for the CodeMaid extension. IIRC, these are all the default values.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if this should be part of the repository, I use codemaid extension and have a local .editorconfig myself but wouldn't commit it, same as I wouldn't commit my local color theme preferences
I may be wrong on this, this is my first time as contributor and is is taking time to learn some contributor etiquette
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I get where you're coming from, and certainly settings that only affect developers at an individual level shouldn't be checked in. .editorconfig can certainly be used to help make one's code consistent, but I think it's primarily meant to declare a team's desired conventions. It's no fun to open a project and find a thousand warnings because another author has broader variance. Committing an .editorconfig sets the baseline so everyone can build the code without warnings.
CodeMaid is much farther into the gray area. On further reflection, I agree that it shouldn't be checked in for OSS projects. I'll remove it.