Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add surrealdb component #5721

Closed
wants to merge 6 commits into from
Closed

Conversation

Odonno
Copy link

@Odonno Odonno commented Sep 15, 2024

Description

Add SurrealDB component to .NET Aspire.

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?
Microsoft Reviewers: Open in CodeFlow

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Sep 15, 2024
@davidfowl davidfowl added area-integrations Issues pertaining to Aspire Integrations packages and removed area-components labels Sep 15, 2024
@Odonno
Copy link
Author

Odonno commented Sep 17, 2024

I am trying to run the tests but the build fails due to PublicAPI txt files. How to fix that?

@Odonno
Copy link
Author

Odonno commented Sep 17, 2024

Can you help me @davidfowl ?

@Alirexaa
Copy link
Contributor

I am trying to run the tests but the build fails due to PublicAPI txt files. How to fix that?

You should add public API signature to PublicAPI.Unshipped.txt
Just use ctr + . on every public api like public class name, pubilc property and method to open intelisense menu and use suggestion.

@Odonno
Copy link
Author

Odonno commented Sep 21, 2024

I am trying to run the tests but the build fails due to PublicAPI txt files. How to fix that?

You should add public API signature to PublicAPI.Unshipped.txt Just use ctr + . on every public api like public class name, pubilc property and method to open intelisense menu and use suggestion.

Visual Studio mystery... Now I can see this suggestion in Intellisense. Thank you for your response anyway.

@Alirexaa
Copy link
Contributor

We need a client component and tests too.
You can find test examples in Aspire.Hosting.PostgreSQL.Tests project.

@Odonno Odonno force-pushed the feat/surrealdb branch 3 times, most recently from 68b17e3 to ae54aed Compare September 23, 2024 19:14
@Odonno
Copy link
Author

Odonno commented Nov 15, 2024

Closed in favor of the PR opened in the CommunityToolkit repository: CommunityToolkit/Aspire#251

@Odonno Odonno closed this Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-integrations Issues pertaining to Aspire Integrations packages community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants