-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a macOS universal binary #313
base: main
Are you sure you want to change the base?
Conversation
<_LipoOuputPath>$(PublishDir)\osx-universal\$(AssemblyName)</_LipoOuputPath> | ||
</PropertyGroup> | ||
|
||
<Exec Command="lipo @(_RidSpecificSingleFile, ' ') -create -output $(_LipoOuputPath)" Condition="$([MSBuild]::IsOSPlatform('OSX'))" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know if you care, but this won't work if any of these paths have spaces in them.
Tested this on a m2 machine and it works as expected:
|
Don't think we do notarization for this. |
@@ -37,4 +37,23 @@ | |||
</EmbeddedResource> | |||
</ItemGroup> | |||
|
|||
<Target Name="PublishMacOSUniversalBinary"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
who/what calls this target?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need help making the macOS build call this - it's one of the questions in the issue description :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably here: https://github.com/dotnet/cli-lab/blob/25e91f1d39ad446131c0fe4bc998c5a33e766773/.vsts-ci.yml#L137C1-L144C33
You can tweak the .yml, then push your branch internal to trigger an official build against your branch, that's the only way to verify yaml changes
Adds a target that
lipo
to create a universal binary (thanks @rolfbjarne!)Things we need to think about:
cc @joeloff / @marcpopMSFT