Refs #1074 - Error message "Required argument {ARGUMENT NAME} missing for command {commandName}..." #1993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… {commandname}", should provide "Required argument {argumentname} missing for command: {commandname}" for better clarity as to which required argument is missing.
| @@ -10,7 +10,7 @@ public class NonWindowsOnlyFactAttribute : FactAttribute | |||
| { | |||
| public NonWindowsOnlyFactAttribute() | |||
| { | |||
| if (RuntimeEnvironment.OperatingSystemPlatform == Platform.Windows) | |||
| if (RuntimeEnvironment.OperatingSystemPlatform == Microsoft.DotNet.PlatformAbstractions.Platform.Windows) | |||
There was a problem hiding this comment.
That looks unrelated. There is a similar change elsewhere in this PR.
| /// </summary> | ||
| public virtual string RequiredArgumentMissing(Argument argument, SymbolResult symbolResult) => | ||
| symbolResult is CommandResult | ||
| ? GetResourceString(Properties.Resources.CommandRequiredArgumentMissing, argument.Name, symbolResult.Token().Value) |
There was a problem hiding this comment.
In the development version I think this should prefer HelpName if set.
Comment on lines
104
to
107
| public virtual string RequiredArgumentMissing(SymbolResult symbolResult) => | ||
| symbolResult is CommandResult | ||
| ? GetResourceString(Properties.Resources.CommandRequiredArgumentMissing, symbolResult.Token().Value) | ||
| ? GetResourceString(Properties.Resources.CommandRequiredArgumentMissing, "(unknown)", symbolResult.Token().Value) | ||
| : GetResourceString(Properties.Resources.OptionRequiredArgumentMissing, symbolResult.Token().Value); |
There was a problem hiding this comment.
Because #2041 made LocalizationResources internal, you can just delete this overload. Then there won't be an "(unknown)" string that might have to be localised.
|
Any eta for this PR? |
jonsequitur
reviewed
Dec 15, 2023
| @@ -52,6 +52,7 @@ | |||
|
|
|||
| <ItemGroup> | |||
| <InternalsVisibleTo Include="System.CommandLine.NamingConventionBinder" /> | |||
| <InternalsVisibleTo Include="System.CommandLine.Tests" /> | |||
There was a problem hiding this comment.
It's good to avoid making internals visible to tests.
|
There are unaddressed comments and merge conflicts that need to be resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it was "Required argument missing for command: {commandname}" - now we have better clarity as to which argument is missing.