Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conversions.md: indent final 2-entry bullet 1 level #1206

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

RexJaeschke
Copy link
Contributor

The 3rd-to-last bullet ends in "as follows:" which sure sounds like what follows should be in a subordinate list. And that is indeed what we had in V5. However, I just noticed that in V6 and subsequent versions, that extra indent level has been removed, which I'm thinking was probably an editorial error introduced during the big conversion from Word to md.

Interestingly, I discovered this as I was researching the claim that in V11, the 2nd-to-last bullet had just been added, but when I looked at the spec, it had been there for many years. So either the V11 MS What's New in V11 text is wrong, or we jumped the gun a long time ago by adding text that wasn't yet true.

@RexJaeschke RexJaeschke added this to the Pre-C# 8.0 milestone Nov 14, 2024
@RexJaeschke RexJaeschke self-assigned this Nov 14, 2024
Copy link
Contributor

@Nigel-Ecma Nigel-Ecma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch @RexJaeschke

I'll :shipit: now

@BillWagner BillWagner merged commit 5d74d23 into dotnet:draft-v8 Nov 15, 2024
6 checks passed
@BillWagner BillWagner deleted the RexJaeschke-patch-2 branch November 15, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants