Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install v2 grammar check #1207

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

BillWagner
Copy link
Member

This installs the updated grammar validator from the private antlr-testing repo.

It's a precursor to updating our validation logic.

This installs the version 2.0.0 From the antlr-testing repo as of 11/14
Copy link
Contributor

@Nigel-Ecma Nigel-Ecma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Merge alongside #1195 after it has been approved

@BillWagner BillWagner merged commit 2b81a82 into dotnet:draft-v8 Nov 22, 2024
3 of 4 checks passed
@BillWagner BillWagner deleted the install-v2-grammar-check branch November 22, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants