Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for ref-valued methods, properties, et al. #837

Closed
wants to merge 10 commits into from
Closed

Changes for ref-valued methods, properties, et al. #837

wants to merge 10 commits into from

Commits on Jul 6, 2023

  1. Configuration menu
    Copy the full SHA
    01551e0 View commit details
    Browse the repository at this point in the history
  2. Typo: missing semicolon (yes I don't have the grammar checker running…

    … locally at the moment :( )
    Nigel-Ecma committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    22ceaf0 View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2023

  1. This is the second stage of this draft PR so it now covers ref indexers.

    Typos found in the first stage have been fixed.
    
    Comments on the first stage also addressed some longer standing issues, these have been addressed which means a few more files have been impacted.
    In particular double-spaces have been removed and some files have bene impacted just for that.
    
    There has been knowen issues with the sharing the clauses related to accessors, currently sub-clauses of Properties, between properties and indexer.
    Some duplication has been removed as part of this, and some *Note*s added. A re-org of some of this material could be warranted but this PR does
    not (currently) do that.
    
    Please review and fire submit your brickbats, and even bouquets, so we can get this sorted before Thursday if possible!
    Nigel-Ecma committed Jul 8, 2023
    Configuration menu
    Copy the full SHA
    a3751a3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    cd13a47 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1af3f87 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    f36e3a3 View commit details
    Browse the repository at this point in the history
  5. Correct some x-refs

    Nigel-Ecma committed Jul 8, 2023
    Configuration menu
    Copy the full SHA
    af69d86 View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2023

  1. This is the first pass at introducing => ref expression bodies to m…

    …ethods.
    
    The existing grammar for *method_declaration* *et al.* tended towards the less restrictive with the prose detailing the myriad of restrictions/combinations allowe/etc. It was quite gnarly at times and adding in returns-by-ref methods, and their set of restrictions, doesn’t help…
    
    The new grammar is a little more precise, though still liberal, which allows some of the prose to be removed (e.g. no need to say something is disallowed when its a grammartical impossibility) while adding in prose for the returns-by-ref case. I.e. I took some of the gnarly stuff out and replaced it new gnarly stuff, I make no claim it is over *less* gnarly just less than it would be wthout the grammar refactor…
    
    Of course the balance between grammar & prose semantic restrictions is subjective rather than objective, feel free to discuss.
    
    Still to do are local & anonymous functions, interfaces, a review of the delegate stuff, maybe something in the overrides…
    
    As before, please review and fire off your brickbats & bouquets and spot those sneaky typos!
    Nigel-Ecma committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    ee818df View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2023

  1. Configuration menu
    Copy the full SHA
    2a9e318 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2023

  1. A replicated Note had been pasted into one too many clauses, with a k…

    …nock-on effect
    
    that a clause list constructed from those with notes was also wrong. Thanks to Jon
    for spotting this!
    
    Also a few typos fixed and minor wording changes.
    Nigel-Ecma committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    a0e7238 View commit details
    Browse the repository at this point in the history