-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/6.0] Update dependencies #34821
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,6 +21,9 @@ | |
|
||
<ItemGroup> | ||
<PackageReference Include="Microsoft.Data.SqlClient" Version="2.1.7" /> | ||
<PackageReference Include="System.Drawing.Common" Version="4.7.3" /> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These ones are real transitive vulnerabilities. Nothing else is going to drop these or update them. Unfortunately SqlClient hasn't shipped an update to address them. Maybe they would consider it? I see version 2.1.7 was shipped less than a year ago. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. They've been informed of this offline, but they don't plan to ship an update as this vulnerability does not affect SqlClient |
||
<PackageReference Include="Microsoft.IdentityModel.JsonWebTokens" Version="6.36.0" /> | ||
<PackageReference Include="Microsoft.IdentityModel.Protocols.OpenIdConnect" Version="6.36.0" /> | ||
</ItemGroup> | ||
|
||
<ItemGroup> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These two indeed are dropped by conflict resolution, so it's annoying we need to specify them. The end up being brought in by Newtonsoft.Json which Cosmos doesn't want to update. Azure/azure-cosmos-dotnet-v3#4674