Remove some unused locals #9573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewnoakes
commented
Oct 29, 2024
| @@ -67,7 +67,6 @@ internal async Task<List<ProjectSystemReferenceInfo>> GetReferencesAsync(Configu | |||
|
|
|||
| private static async Task<bool> GetAttributeTreatAsUsedAsync(IProjectProperties metadata) | |||
| { | |||
| var propertyNames = await metadata.GetPropertyNamesAsync(); | |||
There was a problem hiding this comment.
This is the only change here that has an impact at runtime.
Following a recent PR that improved performance by removing the initialization of a value assigned to an unused variable, I wanted to enable more analyzers to prevent this in future. Unfortunately there's not an analyzer that'll catch all instances of this. Within VS we have `IDE0059` already, and this PR turns it into an error (rather than a hint) but it won't catch everything. The things it did flag are fixed here.
drewnoakes
force-pushed
the
remove-unused-locals
branch
from
802c0c9 to
e1f18e9
Compare
haileymck
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following a recent PR that improved performance by removing the initialization of a value assigned to an unused variable, I wanted to enable more analyzers to prevent this in future.
Unfortunately there's not an analyzer that'll catch all instances of this. Within VS we have
IDE0059already, and this PR turns it into an error (rather than a hint) but it won't catch everything.The things it did flag are fixed here.
Microsoft Reviewers: Open in CodeFlow