Language service tidying #9605
Language service tidying #9605
Conversation
NRT documents this requirement via the type system.
There's no behaviour change here, only hoisting functions into tighter scopes.
drewnoakes
added
the
Feature-Language-Service
| { | ||
| value.Value(context.BinOutputPath, added, removed); | ||
| value(context.BinOutputPath, added, removed); |
There was a problem hiding this comment.
This question is for my own learning.
Why you need this change? is that to gain code cleanness or performance gain?
There was a problem hiding this comment.
ExtensionValues makes the code here a little cleaner, and it also ensures that any MEF exports that might throw when instantiated are filtered out, rather than causing this code to crash.
I guess when I said there was no behaviour change, I should have called this out.
There was a problem hiding this comment.
| @@ -52,6 +53,7 @@ proj | |||
| projectsystem | |||
| projitems | |||
| readonly | |||
| refactorings | |||
There was a problem hiding this comment.
do you need them for future use? or are they used somewhere else?
There was a problem hiding this comment.
This word was used in the code somewhere. While it's not actually a real word in the dictionary, it's common enough in code that I don't think it should be marked as a spelling error.
| { | ||
| value.Value(context.BinOutputPath, added, removed); | ||
| } | ||
| value(context.BinOutputPath, added, removed); |
There was a problem hiding this comment.
This comment should come to here, it is outdated in original place
I'm familiarising myself more deeply with the language service code, ahead of fixing a bug in it.
As part of that familiarisation, I updated the code to use some newer C# features:
To me, this makes the code a bit easier to work with.
I also removed some unused parameters from interfaces and their interfaces. No public changes.
There are no functional changes here. Just reformatting code and removing unused stuff. I wanted to separate this out from the bug fix, which will come in a later PR.
There are quite a few whitespace changes here, which makes the review a bit harder. Might be easiest to disable whitespace in the diff, and go commit-by-commit.
Microsoft Reviewers: Open in CodeFlow