Use file-scoped namespaces #9619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Excludes a few changes that break some of our columnar alignment.
This change was applied automatically in VS, via the Roslyn codefix.
This file tells git/GitHub to ignore certain commits from the blame view. The file is configured to exclude a recent solution-wide conversion from block-scoped to file-scoped namespaces, which touched most lines in the repo. With this, GitHub's blame view will ignore the change, making browsing changes on GitHub easier.
melytc
approved these changes
Dec 11, 2024
|
VS's CodeLens doesn't respect the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our team meeting today we agreed to convert the repository to use file-scoped namespaces through the repo.
Since the feature was added to C#, we have been using it in new files, and adding it to old files when working on them.
This approach has two downsides:
We decided to bite the bullet and make this change in one go across the entire repository.
This PR also adds a
.git-blame-ignore-revsfile that tells git to ignore the particular commit ingit blameoperations, meaning this PR won't be displayed in blame views.We use the
.editorconfigfile to set the use of block-scoped namespaces as an error, to prevent their use in future.Microsoft Reviewers: Open in CodeFlow