Honour users' settings as a starting point for Razor formatting #76066
+25
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
davidwengier
force-pushed
the
RazorFormattingDefaults
branch
from
d066a2c
to
e2ba725
Compare
|
@davidwengier I'm confused. The linked issues repro in VS, but the PR is changing O# ExternalAccess. |
|
The change to O# is just to satisfy the interface change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In dotnet/razor#6166 we changed Razor to pass indentation options into a Roslyn service, rather than create a workspace and apply changes to it, etc. Sadly this regressed C# formatting in Razor files, because the code was just creating a new
CSharpSyntaxFormattingOptionsand not starting from the users settings.Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2305075
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2305404