Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added settings to disable ad URLs and images. #22

Open
wants to merge 1 commit into
base: v3
Choose a base branch
from

Conversation

jaydensmith
Copy link

I don't always need URLs and images for more complex ads. I've added some settings to be able to disable these.

@reachalan
Copy link

This would be very helpful on a project im currently working on.

@lindseydiloreto
Copy link
Contributor

I guess I never addressed the original post, sorry. What is the use-case for omitting images and/or URLs?

Would you mind giving a bit more detail as to what exactly you are doing and why it would be helpful?

@reachalan
Copy link

We have some ads that are entered using a third party script (through a custom field). Those ads dont need an image or url, because that gets pulled in via the script. For example, a google tag ad script.

@lindseydiloreto
Copy link
Contributor

Interesting. And in this scenario, what are the advantages to using Ad Wizard?

For the tracking? We might need to make some adjustments to accommodate if the image and/or URL were missing, not sure how far this PR goes to cover the Views and Clicks.

Or for Craft's internal organization structure? Or for something else?

Thanks, just trying to wrap my head around all the ways people are using this plugin. 🙂

@reachalan
Copy link

Definitely for the internal organizational structure, but we also have the regular type of ads with images that the plugin was designed for. And its simplest to keep all the ads organized within the plugin. Then content authors select which ads they want to display within pages or templates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants