Features/support actions #292
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… that getValue exposes getResponse (no idea why it was mismapped, legacy reasons?).
…here in the first place; but it was injecting an extra div with data-action=undefined that was breaking the expected functionality. With the extra div eliminated, this works for both V2 and V3 using "import ReCAPTCHA from ./recaptcha;"
|
In the meantime I've published a scoped package at @9swampy/react-google-recaptcha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements support for Enterprise Action names #289.
As I'm a windows user made a little tweak so the build process is platform independent (clean.js).
The last commit's the important one. Tbh I'm not sure why the eliminated div was there in the first place; but it was injecting an extra div with data-action=undefined that was breaking the expected functionality. With the extra div eliminated, this works for both V2 and V3 using "import ReCAPTCHA from ./recaptcha;"
I've not verified "import RecaptchaWrapper from ./recaptcha-wrapper;"
I've also added a test for getValue mapping to getResponse (not sure why you mapped like this but it threw me off so adding documentation so it doesn't get changed accidentally by someone else going down the same rabbit hole I went down).
@hartzis @nike1v too - there's several long standing PRs on here that look good; adding another. Ofc I appreciate you and @dozoisch are all busy... hence I've tried to keep the PR clean and easy; to that end had to close and reopen to fix lint issues.