Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First iteration of model install mechanism. #55

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

First iteration of model install mechanism. #55

wants to merge 2 commits into from

Conversation

dpalmasan
Copy link
Owner

Trying to follow a similar approach that spaCy lib follows:

  • Create a Language object that holds language data
  • Create load method that loads Language model from file

TODO:

  • Utility to download models
  • What metadata could we add for models?
  • What is the definition of a model?

@dpalmasan dpalmasan marked this pull request as draft April 19, 2021 02:03
dpalmasan
dpalmasan commented Nov 3, 2021
View reviewed changes
Copy link
Owner Author

@dpalmasan dpalmasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs some work on configs and polishing loaders

src/TRUNAJOD/__init__.py

:param name: Model name
:type name: Union[str, Path]
:return: A TRUNAJOD language model.
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check language config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dpalmasan