Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SD-22] Updated hero theme image #555

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

yeniatencio
Copy link
Contributor

@yeniatencio yeniatencio commented Nov 26, 2024

Jira

https://digital-vic.atlassian.net/browse/SD-22
BE testing link: https://nginx-php.pr-468.content-reference-sdp-vic-gov-au.sdp4.sdp.vic.gov.au/

Note

This is a new PR based on the initial implementation on this PR
After further testing the AJAX approach suggested, I noticed there was an scenario that didn't work which it is related to this bug. So, I am reverting back to full JS solution.

Problem/Motivation

We want to have these scenarios for customised header:

  1. Corner graphics - Light + Dark (Both options available and by default Light should be selected),
  2. Full background image - Dark only (Only one option should be set)
  3. CTA - Light only (Only one option should be set).
  4. Default appearance - Light only (Only one option should be set)

Fix

  1. Set field field_landing_page_hero_theme to mandatory.
  2. Remove a patch for drupal/jsonapi_extras as new released was done and patch is not needed anymore.
  3. Fix typo in label : Here image theme.
  4. Updated behat test.
  5. Updated tide publication module to make it work in publication and publication page content type.

Related PRs

Screenshots

As discussed, the script was working since the code for attaching the library already existed.

Screenshot 2024-11-26 at 11 20 32 pm

Testing for Landing page, publication and publication page:

Screenshot 2024-11-27 at 12 26 20 am Screenshot 2024-11-27 at 12 25 46 am Screenshot 2024-11-27 at 12 25 14 am

TODO

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants