Settings for media alias display for documents type #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharmasahil
requested review from
vincent-gao,
MdNadimHossain,
anthony-malkoun and
yeniatencio
vincent-gao
requested changes
Nov 28, 2024
vincent-gao
approved these changes
Nov 28, 2024
|
ready for test |
Thanks for the approval @vincent-gao, moved it to QA, we need to still review the media_library dependency for this new module before we merge it. |
|
hey @sharmasahil , could you please fix the failed build |
Fixed the build. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira
https://digital-vic.atlassian.net/browse/SD-518
Problem/Motivation
Media library - allow alias for media items
Fix
Integrated new media file alias module with only document file type enabled. Also this module depends on media library from core which seems not enabled globally. Please advise if we can enable it too.
Related PRs
Screenshots
TODO