Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes KafkaConsumer examples in README.rst #2444

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yassinecharjami
Copy link

@yassinecharjami yassinecharjami commented Jul 18, 2024

in the README.rst files KafkaConsumer take as argument the topic which is not correct, i corrected the two first examples from:

from kafka import KafkaConsumer
consumer = KafkaConsumer('my_favorite_topic')
for msg in consumer:
... print (msg)

join a consumer group for dynamic partition assignment and offset commits

from kafka import KafkaConsumer
consumer = KafkaConsumer('my_favorite_topic', group_id='my_favorite_group')
for msg in consumer:
... print (msg)

to:

from kafka import KafkaConsumer
consumer = KafkaConsumer(bootstrap_servers='localhost:1234')
consumer.subscribe(['my_favourite_topic'])
for msg in consumer:
... print (msg)

join a consumer group for dynamic partition assignment and offset commits

from kafka import KafkaConsumer
consumer = KafkaConsumer(bootstrap_servers='localhost:1234', group_id='my_favorite_group')
consumer.subscribe(['my_favourite_topic'])
for msg in consumer:
... print (msg)

Thanks


This change is Reviewable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant