Always upload old style and new style methodologies

[dormi]

Spec

In CE we exported old methodologies with version = 2
In Pro we exported new methodologies with version = 2

We cannot check the template version to know how to upload methodologies.
We can just check which methodologies come with the file to upload and upload them.

How to test

Old files (version = 2) containing new or old methodologies, must upload the methodologies correctly both in Pro and CE

[brianp]

In the event a methodology is imported by process_v1_methodologies(template) does process_v2_methodologies(template) essentially become a no-op?
Or vice-versa. It'll run but nothing will happen?

[dormi]

Exactly, that is the idea.
The code is already there:
If no old style methodologies are present, we just return: https://github.com/dradis/dradis-projects/blob/master/lib/dradis/plugins/projects/upload/v3/template.rb#L169
If no new methodologies are present, we don't enter the loop:
https://github.com/dradis/dradis-projects/blob/master/lib/dradis/plugins/projects/upload/v3/template.rb#L130
I thought on adding an explicit return in new methodologies too. But I think it works like this.

[brianp]

I have one small question about running both versions of the code. Assuming no performance implications, and running it won't create any kind of duplication I think it's good to move to staged.