remove todos (they're raised by analyzer)

dragonfruitnetwork · Dec 19, 2023 · 9274a01 · 9274a01
1 parent 321ab40
commit 9274a01
Showing 1 changed file with 0 additions and 4 deletions.
diff --git a/DragonFruit.Data.Roslyn/ApiRequestSourceGenerator.cs b/DragonFruit.Data.Roslyn/ApiRequestSourceGenerator.cs
@@ -224,7 +224,6 @@ private static RequestSymbolMetadata GetRequestSymbolMetadata(Compilation compil
                     // only allow public, protected and protected internal properties
                     if (candidate.DeclaredAccessibility is Accessibility.Private or Accessibility.Internal)
                     {
-                        // todo diagnostic warning
                         continue;
                     }
 
@@ -239,7 +238,6 @@ private static RequestSymbolMetadata GetRequestSymbolMetadata(Compilation compil
                     // if a method is declared, ensure it's not void
                     if (returnType.SpecialType == SpecialType.System_Void)
                     {
-                        // todo return diagnostic warning
                         continue;
                     }
 
@@ -254,14 +252,12 @@ private static RequestSymbolMetadata GetRequestSymbolMetadata(Compilation compil
 
                     if (candidateMethod == null)
                     {
-                        // todo return diagnostic warning (no getter)
                         continue;
                     }
 
                     // inherited properties that are private or internal are ignored
                     if (depth > 0 && candidateMethod.DeclaredAccessibility is Accessibility.Private or Accessibility.Internal)
                     {
-                        // todo return diagnostic warning (getter not accessible)
                         continue;
                     }