-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2024 Source Generator Rewrite #140
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update essentially rewrites most of the library to be more consise and easier to use.
Major Changes
Moving to semantic versioning
From now on, the project will use semantic versioning due to source generators being liable to breaking mixed libraries (as some may now have source-generated request building methods)
This will be release v4.0.0:
(Breaking) Older NuGet packages will be delisted to maintain correct versioning in IDEs
Serializer class name changes
ApiSystemJsonSerializer
is nowApiJsonSerializer
(and is supplied within the main data project)ApiHtmlSerializer
is nowHtmlSerializer
ApiJsonSerializer
is nowNewtonsoftJsonSerializer
ApiRequest changes
internal
andprivate
members will be ignoredPath
has changed toRequestPath
Method
has been renamed toRequestMethod
and now suppliesHttpMethod
(class) instead ofMethod
(enum)[QueryParameter]
/[FormParameter]
has been removed and replaced with[RequestParameter(ParameterType.Query, "name"]
/[RequestParameter(ParameterType.Form, "name"]ApiDownloadRequest
class has been removed and replaced in favour of usingApiRequest
and ApiClient.PerformDownload(request, destinationStream)`.ApiClient changes
HttpRequestHeaders
, the old header container has been removedMigration Guide and Docs need to be written before a v4.0.0 release ()